Hi Bruce, On 03/26/2015 02:35 PM, Bruce Richardson wrote: > On Wed, Mar 25, 2015 at 06:00:34PM +0100, Olivier Matz wrote: >> Add a new private_size field in mbuf structure that should >> be initialized at mbuf pool creation. This field contains the >> size of the application private data in mbufs. >> >> Introduce new static inline functions rte_mbuf_from_baddr() >> and rte_mbuf_to_baddr() to replace the existing macros, which >> take the private size in account when attaching and detaching >> mbufs. >> >> [...] > > Why does this new field need to go in cache line zero? New fields should go > by default in cache line 1, where there is more space, unless there is a > compelling > reason not to. Space in cache line 0 is at a premium.
You are right, having this in the second cache line makes more sense, I'll change that in the v2. Thanks for your review, Olivier
