2022-04-01 17:31 (UTC+0100), Bruce Richardson:
> On Fri, Apr 01, 2022 at 12:28:30AM +0300, Dmitry Kozlyuk wrote:
[...]
> > + if is_source or name == 'meson.meson.build':
>
> duplicate "meson."
Thanks!
> > + path = os.path.join(root, name)
> > + if is_source:
> > + sources.append(path)
> > + print(path , end=' ', file=dep)
> > +
> > +sys.stdout = open(api_examples, 'w')
>
> While this is a literal translation of what is done in the .sh file, I
> wonder if, for consistency, in the python versions we should always either
> use stdout redirection or always use "file=" option to printing. Right now
> we have a mix of both.
I was wondering about this too.
Will change to "file=" (see also below) because explicit is better.
> > +print('/**')
> > +print('@page examples DPDK Example Programs')
> > +print()
>
> Is this additional print done deliberately for clarity vs just putting '\n'
> on previous line?
Yes. I think '''-string will be cleaner, especially with "file=".
