On 3/28/22 10:07, David Marchand wrote:
On Thu, Mar 24, 2022 at 1:46 PM Maxime Coquelin <[email protected]> wrote:This patch ensures virtqueue metadata are not being modified while rte_vhost_vring_call() is executed. Fixes: 6c299bb7322f ("vhost: introduce vring call API") Cc: [email protected] Signed-off-by: Maxime Coquelin <[email protected]> --- lib/vhost/vhost.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c index bc88148347..2f96a28dac 100644 --- a/lib/vhost/vhost.c +++ b/lib/vhost/vhost.c @@ -1291,11 +1291,15 @@ rte_vhost_vring_call(int vid, uint16_t vring_idx) if (!vq) return -1; + rte_spinlock_lock(&vq->access_lock); + if (vq_is_packed(dev)) vhost_vring_call_packed(dev, vq); else vhost_vring_call_split(dev, vq); + rte_spinlock_unlock(&vq->access_lock); + return 0; }Reviewed-by: David Marchand <[email protected]> You can probably merge quickly this fix regardless of the rest of the stats series. It would help me with a series of mine that annotates vhost locks.
Thanks for the review. Applied this single patch to next-virtio tree. Maxime
