08/03/2022 19:52, Usama Arif:
> check-symbols-maps.sh runs with the -e option to exit as soon as
> there is an error. Currently the build is failing as the search of
> grep -L is empty (which is the case for all version.map files as
> they have the local symbol) which causes the script to return
> with an error.
It depends on the shell I guess because most machines run well.
> This patch encapsulates the grep call in a function, so that only the function
> errors out and the build is successful.
That's a strange workaround. I don't understand why it works.
I am submitting a simpler fix adding " || true"
> -local_miss_maps=$(grep -L 'local: \*;' $@)
> +find_local_miss_maps ()
> +{
> + local local_miss_maps=$(grep -L 'local: \*;' $@)
> + echo "$local_miss_maps"
> +
> +}
> +
> +local_miss_maps=$(find_local_miss_maps $@)
Thanks for raising the issue and proposing a solution.
