On Thu, Mar 3, 2022 at 12:30 PM Nithin Dabilpuram
<ndabilpu...@marvell.com> wrote:
>
> Revert change to return error on case where no slab of free
> resources is found. That error check break's a case where
> there is a spare schq to be reused that was just allocated
> for sake of contiguous static TM nodes.
>
> Fixes: 14f7e5d4bf2d ("common/cnxk: add missing checks of return values")
> Cc: gmuthukri...@marvell.com
>
> Signed-off-by: Nithin Dabilpuram <ndabilpu...@marvell.com>
Acked-by: Jerin Jacob <jer...@marvell.com>
Updated the git commit as follows and applied to
dpdk-next-net-mrvl/for-next-net. Thanks
common/cnxk: fix bitmap usage for TM
Revert change [1] to return error on case where no slab of free
resources is found. That error check break's a case where
there is a spare schedule queue to be reused that was just
allocated for sake of contiguous static TM nodes.
[1]
Fixes: 14f7e5d4bf2d ("common/cnxk: add missing checks of return values")
Signed-off-by: Nithin Dabilpuram <ndabilpu...@marvell.com>
Acked-by: Jerin Jacob <jer...@marvell.com>
> ---
> drivers/common/cnxk/roc_nix_tm.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_nix_tm.c
> b/drivers/common/cnxk/roc_nix_tm.c
> index 7a17780..5b70c7b 100644
> --- a/drivers/common/cnxk/roc_nix_tm.c
> +++ b/drivers/common/cnxk/roc_nix_tm.c
> @@ -1042,10 +1042,8 @@ nix_tm_assign_hw_id(struct nix *nix, struct
> nix_tm_node *parent,
> return -EFAULT;
> }
>
> - if (!slab) {
> - if (!plt_bitmap_scan(bmp, &pos, &slab))
> - return -ENOENT;
> - }
> + if (!slab)
> + plt_bitmap_scan(bmp, &pos, &slab);
>
> if (child->priority == parent->rr_prio && spare_schq != -1) {
> /* Use spare schq first if present */
> --
> 2.8.4
>
