09/02/2022 14:52, Ferruh Yigit: > On 2/9/2022 7:24 AM, Weiguo Li wrote: > > +#ifndef RTE_KNI_FIFO_H > > +#define RTE_KNI_FIFO_H > > It doesn't really differ much but other kni header guards wrapped with '_', > I don't now why.
No good reason I think. > If there will be a new version can you please apply the same here to have > consistency, like: > #ifndef _RTE_KNI_FIFO_H_ I think consistency is not important here. We should not add underscores where not needed, it gives a false impression of reserved keywords.
