Re: [PATCH v2 1/3] net/ark: add device capabilities record

[Ferruh Yigit]

On 2/11/2022 11:39 AM, John Miller wrote:

Add a device capabilities record for supported features.
Certain variants require that PCIe read-requests be correctly
throttled. This is called "rqpacing" in Arkville, and has to do
with credit and flow control on certain Arkville implementations.

Signed-off-by: John Miller <john.mil...@atomicrules.com>

---
v2:
- Improved code readability and comments.
---
  drivers/net/ark/ark_ethdev.c | 88 +++++++++++++++++++++++++++++-------
  1 file changed, 71 insertions(+), 17 deletions(-)

diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index b618cba3f0..9f5f375174 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -85,17 +85,53 @@ static const char * const valid_arguments[] = {
        NULL
  };

+#define AR_VENDOR_ID 0x1d6c

  static const struct rte_pci_id pci_id_ark_map[] = {
-       {RTE_PCI_DEVICE(0x1d6c, 0x100d)},
-       {RTE_PCI_DEVICE(0x1d6c, 0x100e)},
-       {RTE_PCI_DEVICE(0x1d6c, 0x100f)},
-       {RTE_PCI_DEVICE(0x1d6c, 0x1010)},
-       {RTE_PCI_DEVICE(0x1d6c, 0x1017)},
-       {RTE_PCI_DEVICE(0x1d6c, 0x1018)},
-       {RTE_PCI_DEVICE(0x1d6c, 0x1019)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100d)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100e)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100f)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1010)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1017)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1018)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1019)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},

Here two new device support added, can you please separate it
to its own patch?

Also is this new device support deserve driver documentation
or release notes update?