14/02/2022 10:13, Tyler Retzlaff: > while the driver api is "internal" we agreed some time ago that drivers > could be built external to the dpdk tree. by enabling the meson setup > option -Denable_driver_sdk=true. > > it was agreed that the driver api was internal and would attract no > binary compatibility support which was fine. this change has now > imposed a further restriction that out of tree drivers have to be > authored in C only as non-C++ compatible code will invariably leak into > the internal structures. > > you won't allow us to build C++ drivers in the dpdk tree and it seems > now you are preventing building of C++ drivers outside of the tree too.
That's the problem of non-written assumptions, they are unknown or forgotten. Did we agree to support out-of-tree drivers in C++? We really need to make things clear and written in documentation. > could we please re-evaluate this. Yes we can re-evaluate. What is the list of impacted files? > commit 7a335720575507f55b723b1e10bfea7daeba1386 > Author: Thomas Monjalon <tho...@monjalon.net> > Date: Wed Sep 15 18:46:35 2021 +0200 > > lib: remove C++ include guard from private headers > > The private headers are compiled internally with a C compiler. > Thus extern "C" declaration is useless in such files. > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
