On 2/8/2022 1:50 PM, Jeff Daly wrote:
moved response down, please don't top post.
-----Original Message-----
From: Ferruh Yigit <ferruh.yi...@intel.com>
Sent: Monday, February 7, 2022 11:04 AM
To: Wang, Haiyue <haiyue.w...@intel.com>; Stephen Douthit <steph...@silicom-usa.com>; Morten Brørup
<m...@smartsharesystems.com>; Lu, Wenzhuo <wenzhuo...@intel.com>; Zhang, Helin
<helin.zh...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>
Cc: dev@dpdk.org; Wen Wang <w...@silicom-usa.com>; sta...@dpdk.org
Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is
supported before write
Caution: This is an external email. Please take care when clicking links or
opening attachments.
On 1/19/2022 12:31 AM, Wang, Haiyue wrote:
-----Original Message-----
From: Stephen Douthit <steph...@silicom-usa.com>
Sent: Wednesday, January 19, 2022 05:06
To: Wang, Haiyue <haiyue.w...@intel.com>; Morten Brørup
<m...@smartsharesystems.com>; Lu, Wenzhuo <wenzhuo...@intel.com>;
Zhang, Helin <helin.zh...@intel.com>; Zhang, Qi Z
<qi.z.zh...@intel.com>
Cc: dev@dpdk.org; Wang, Wen <w...@silicom-usa.com>; sta...@dpdk.org
Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate
select is supported before write
On 12/22/21 19:55, Wang, Haiyue wrote:
OK, let's see in 2022, happy holidays. ;-)
A bit of a slower start to 2022 than I had hoped, but I have a v3 of
the hotplug fix in progress. It's now working for the 82599 and
C3000 ixgbe devices under Linux, and I'm in the process of getting
this built and tested under FreeBSD.
Assuming the FreeBSD testing comes together smoothly my plan is to
split these patches into three series:
1) The SFP hotplug fix
2) Refactor SDP3 TX_DISABLE 82599 link check stuff
3) Support of additional SFP types under ixgbe
My focus right now is on the SFP hotplug fix, so please let me know
if there's any additional feedback on that portion of the original series.
Right now the feedback I have that impacts the hotplug fix is a
cleanup for patch 1, and the general comment that changes to files
under ixgbe/base are usually backported from Linux, and so I should
refactor my changes to live in ixgbe_ethdev.c
Yeah, just put the change in base code to *separate patch*, so that
they are easily to be reviewed, thanks.
Hi Steve, Wen, Haiyue,
Can you please clarify the above change request?
I though it is related to splitting base code updates into their own patches,
but that already seems the case in set (except from a few minor mix).
And what is the status, is there a new version worked on? Or is the set waiting
for more review?
Ferruh,
Stephen has passed on support of his patches to me, I will be the main
point of contact going forward. I'm still ramping up on the code, expect patch
updates to come from me in the future.
Hi Jeff,
What is the planned changes in the next version?
I just want to be sure that we are on same page with the change request,
to not waste effort/time.
Haiyue, perhaps can you articulate the request again?
