03/02/2022 11:57, Ferruh Yigit: > On 2/2/2022 11:50 AM, Thomas Monjalon wrote: > >>> Subject: [PATCH] net/enic: adjust memory check and use in proper order > >>> > >>> Fixes: bb66d562aefc ("net/enic: share flow actions with same signature") > >>> > >>> Signed-off-by: Weiguo Li <liw...@foxmail.com> > >>> > >>> Reviewed-by: John Daley <johnd...@cisco.com> > >>> > >> Applied to dpdk-next-net/main, thanks. > > > > Please could we have a little of explanation in the commit log? > > The title says "adjust [...] and use in proper order" > > but I see only a move of the check. > > > > > > Is following good? If so I can update it in next-net. > > net/enic: fix dereference before null check > > Move memcpy to 'ah->key' after 'ah' null check > > Fixes: bb66d562aefc ("net/enic: share flow actions with same signature") > Cc: sta...@dpdk.org
Looks better to me, thanks.