> -----Original Message----- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Monday, March 16, 2015 1:19 PM > To: Mcnamara, John > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal: fix Wbad-function-cast warning > > > This looks reasonable, but it rather begs the question as to why we need > rte_align_floor_int in the first place. Theres only one other call site, > and it looks like it could use RTE_PTR_ALIGN_FLOOR just as easily. What > about fixing up the second call site and removing the function to save > some space?
Hi Neil, Seems like a good idea. I'll submit a v2. Does rte_align_floor_int() need to be deprecated in some way or is it okay to just remove it? John
