[dpdk-dev] [PATCH] null: Fix dereference before null check in eth_null_copy_tx()

[Tetsuya Mukawa]

This patch fixes potential null pointer access of eth_null_copy_tx().

Reported-by: Mcnamara, John <john.mcnamara at intel.com>
Signed-off-by: Tetsuya Mukawa <mukawa at igel.co.jp>
---
 lib/librte_pmd_null/rte_eth_null.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_pmd_null/rte_eth_null.c 
b/lib/librte_pmd_null/rte_eth_null.c
index 86307eb..8a20c9d 100644
--- a/lib/librte_pmd_null/rte_eth_null.c
+++ b/lib/librte_pmd_null/rte_eth_null.c
@@ -160,11 +160,12 @@ eth_null_copy_tx(void *q, struct rte_mbuf **bufs, 
uint16_t nb_bufs)
 {
        int i;
        struct null_queue *h = q;
-       unsigned packet_size = h->internals->packet_size;
+       unsigned packet_size;

        if ((q == NULL) || (bufs == NULL))
                return 0;

+       packet_size = h->internals->packet_size;
        for (i = 0; i < nb_bufs; i++) {
                rte_memcpy(h->dummy_packet, rte_pktmbuf_mtod(bufs[i], void *),
                                        packet_size);
-- 
1.9.1