On 1/11/2022 2:54 PM, Kevin Traynor wrote:
On 05/01/2022 10:32, Maxime Gouin wrote:
reported by code analysis tool C++test (version 10.4):


Hi Maxime,

Can you please give some information on this tool?

Thanks,
ferruh

/build/dpdk-20.11/drivers/net/nfp/nfpcore/nfp_target.h
375   Condition "island < 1" is always evaluated to false
415   Condition "island < 1" is always evaluated to false
547   Condition "target < 0" is always evaluated to false

All of these conditions have the same error. They call
NFP_CPP_ID_ISLAND_of or NFP_CPP_ID_TARGET_of which return a uint8_t and
put the result in "island" or "target" which are integers. These variables
can only contain values between 0 and 255.

Fixes: c7e9729da6b5 ("net/nfp: support CPP")


Cc: sta...@dpdk.org

Signed-off-by: Maxime Gouin <maxime.go...@6wind.com>
Reviewed-by: Olivier Matz <olivier.m...@6wind.com>
---

Acked-by: Kevin Traynor <ktray...@redhat.com>


For series,
Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com>

Series applied to dpdk-next-net/main, thanks.

Reply via email to