On 12/30/2021 6:08 AM, Yanling Song wrote:
This commit adds interfaces to add/remove MAC addresses and registers related ops to struct eth_dev_ops. Furthermore, this commit adds callback to handle link events.
The patch also adds the VF dev_ops. It would be more clear to support PF first and add mbox support and VF later. But VF support is crept into the code from early patches, I assume that is because the driver is already complete and spliting it is hard at this stage.. Similarly the primary/secondary support seems spread through the patches, hard to separate the feature. Above are sign of the patches are not split logically which makes harder to review them and detect any issues, and future fixes references won't be clear. If you can clarify the split more, that would be great but I can see it is hard with an existing driver.
Signed-off-by: Yanling Song <son...@ramaxel.com>
