On 1/14/2022 4:24 PM, Stephen Hemminger wrote:
On Fri, 14 Jan 2022 17:18:19 +0200
Tudor Cornea <tudor.cor...@gmail.com> wrote:
+module_param(min_scheduling_interval, long, 0644);
+MODULE_PARM_DESC(min_scheduling_interval,
+"\t\tKni thread min scheduling interval (default=100 microseconds):\n"
+"\t\t"
+);
+
+module_param(max_scheduling_interval, long, 0644);
+MODULE_PARM_DESC(max_scheduling_interval,
+"\t\tKni thread max scheduling interval (default=200 microseconds):\n"
+"\t\t"
+);
Please don't add more bad module parameter strings.
The KNI author did something no other kernel modules do with tabs
and double spacing, stop this bogus stuff.
The patch is good, let's not block it for the module parameter string,
all can be fixed with another patch.
Can you please give a sample what is a common way of it, me or Tudor can
do the patch?
Is there any reason you have to use KNI at all.
KNI is broken on many levels and is not fixable.
What about virtio or tap?
