Hi Konstantin, > > > Hardware IP reassembly may be incomplete for multiple reasons like > > > reassembly timeout reached, duplicate fragments, etc. > > > To save application cycles to process these packets again, a new > > > mbuf ol_flag (RTE_MBUF_F_RX_IPREASSEMBLY_INCOMPLETE) is added to > > > show that the mbuf received is not reassembled properly. > > > > If we use dynfiled for data, why not use dynflag for > > RTE_MBUF_F_RX_IPREASSEMBLY_INCOMPLETE? > > That way we can avoid introduced hardcoded (always defined) flags for that > > case. > > I have not looked into using dynflag. Will explore if it can be used. The intent of adding this feature is to reduce application cycles for IP reassembly. But if we use dynflag, it will take a lot of cycles to check if dyn flag is set or not. As I understand, it first need to be looked up in a linked list and then checked. And this will be checked for each packet even if there is no reassembly involved.
- RE: [PATCH 2/8] ethdev: add dev ... Ananyev, Konstantin
- RE: [PATCH 2/8] ethdev: add ... Akhil Goyal
- RE: [PATCH 2/8] ethdev: add ... Akhil Goyal
- RE: [PATCH 2/8] ethdev: add ... Ananyev, Konstantin
- [PATCH 3/8] ethdev: add mbuf dynfield for incomplete I... Akhil Goyal
- RE: [PATCH 3/8] ethdev: add mbuf dynfield for inc... Ananyev, Konstantin
- RE: [PATCH 3/8] ethdev: add mbuf dynfield for... Akhil Goyal
- RE: [PATCH 3/8] ethdev: add mbuf dynfield... Ananyev, Konstantin
- RE: [PATCH 3/8] ethdev: add mbuf dynf... Akhil Goyal
- RE: [PATCH 3/8] ethdev: add mbuf... Ananyev, Konstantin
- RE: [PATCH 3/8] ethdev: add mbuf dynfield... Akhil Goyal
- RE: [PATCH 3/8] ethdev: add mbuf dynf... Ananyev, Konstantin
- RE: [PATCH 3/8] ethdev: add mbuf... Akhil Goyal
- [PATCH 4/8] security: add IPsec option for IP reassemb... Akhil Goyal
- [PATCH 5/8] app/test: add unit cases for inline IPsec ... Akhil Goyal
- [PATCH v2 0/4] app/test: add inline IPsec and rea... Akhil Goyal
- [PATCH v2 1/4] app/test: add unit cases for i... Akhil Goyal
- [PATCH v2 2/4] app/test: add IP reassembly ca... Akhil Goyal
- [PATCH v2 3/4] app/test: add IP reassembly ca... Akhil Goyal
- [PATCH v2 4/4] app/test: add IP reassembly ne... Akhil Goyal
- [PATCH 6/8] app/test: add IP reassembly case with no f... Akhil Goyal