Hi,
> -----Original Message-----
> From: Michael Baum <michae...@nvidia.com>
> Sent: Thursday, December 16, 2021 8:41 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <ma...@nvidia.com>; Raslan Darawsheh
> <rasl...@nvidia.com>; Slava Ovsiienko <viachesl...@nvidia.com>; Michael
> Baum <michae...@nvidia.com>; sta...@dpdk.org
> Subject: [PATCH] common/mlx5: fix missing validation in devargs parsing
>
> From: Michael Baum <michae...@nvidia.com>
>
> The rte_kvargs_parse function parses the arguments
> "key=value,key=value,..." string and return an allocated structure that
> contains a key/value list.
> It enables also to send a key without value and updates the values in the
> following ways:
> - "key=value,key,..." - value is updated as NULL.
> - "key=value,key=,..." - value is updated as "" (empty string).
>
> Mlx5 PMDs use this function to parse, but they don't support key without
> value. They send the value as an argument to strtol function.
> When strtol gets NULL as a parameter it cause a crash, when it gets ""
> (empty string) it returns 0.
>
> Adds a check that will prevent an argument in these formats, and returns an
> error for it.
>
> Fixes: 85209924039c4 ("common/mlx5: share memory related devargs")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Michael Baum <michae...@nvidia.com>
> Acked-by: Matan Azrad <ma...@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
