From: Ajit Khaparde <ajit.khapa...@broadcom.com>
Validate the pointers in rxq before accessing them.
Otherwise it can cause a segfault.
Fixes: 657c2a7f1dd4 ("net/bnxt: create aggregation rings when needed")
Cc: sta...@dpdk.org
Signed-off-by: Ajit Khaparde <ajit.khapa...@broadcom.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.pura...@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.ko...@broadcom.com>
---
drivers/net/bnxt/bnxt_rxq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
index 9f1d1d4..cd3bb14 100644
--- a/drivers/net/bnxt/bnxt_rxq.c
+++ b/drivers/net/bnxt/bnxt_rxq.c
@@ -214,7 +214,9 @@ void bnxt_rx_queue_release_mbufs(struct bnxt_rx_queue *rxq)
}
}
/* Free up mbufs in Agg ring */
- if (!bnxt_need_agg_ring(rxq->bp->eth_dev))
+ if (rxq->bp == NULL ||
+ rxq->bp->eth_dev == NULL ||
+ !bnxt_need_agg_ring(rxq->bp->eth_dev))
return;
sw_ring = rxq->rx_ring->ag_buf_ring;
--
2.10.1
