2021-11-30 17:05 (UTC-0800), Jie Zhou:
> On Wed, Nov 24, 2021 at 01:02:06AM +0300, Dmitry Kozlyuk wrote:
[...]
> > [...]
> > > diff --git a/app/test/test_cmdline.c b/app/test/test_cmdline.c
> > > index 115bee966d..9a76bd299f 100644
> > > --- a/app/test/test_cmdline.c
> > > +++ b/app/test/test_cmdline.c
> > > @@ -31,6 +31,7 @@ test_cmdline(void)
> > > return -1;
> > > if (test_parse_num_invalid_param() < 0)
> > > return -1;
> > > +#ifndef RTE_EXEC_ENV_WINDOWS
> > > printf("Testing parsing IP addresses...\n");
> > > if (test_parse_ipaddr_valid() < 0)
> > > return -1;
> > > @@ -38,6 +39,7 @@ test_cmdline(void)
> > > return -1;
> > > if (test_parse_ipaddr_invalid_param() < 0)
> > > return -1;
> > > +#endif
> > > printf("Testing parsing strings...\n");
> > > if (test_parse_string_valid() < 0)
> > > return -1;
> >
> > What's wrong with parsing IP addresses on Windows?
> >
> test_cmdline_ipaddr.c uses linux netinet/in.h specific u6_addr. Skip these
> 3 cases for now and prefer a separate patch to make it work on Windows. Or
> maybe there is already DPDK support on this which I am not aware of? Thanks.
Understood, only please explain this in the commit log.
