Re: [PATCH v2] net/iavf: fix pointer of meter data

[Ferruh Yigit]

On 11/11/2021 6:31 AM, Alvin Zhang wrote:

This patch fixes coverity issue by directly passing the address
of the meter data to lower function.

Coverity issue: 373867

Fixes: 91f27b2e39ab ("net/iavf: refactor RSS")

As far as I can see fixed commit is:
Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF")

I will update in the next-net, can you please double check?

Cc: sta...@dpdk.org

Signed-off-by: Alvin Zhang <alvinx.zh...@intel.com>
---
  drivers/net/iavf/iavf_hash.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c
index 55d8a11..5e0888e 100644
--- a/drivers/net/iavf/iavf_hash.c
+++ b/drivers/net/iavf/iavf_hash.c
@@ -1261,10 +1261,9 @@ struct rss_attr_type {
  static int
  iavf_hash_parse_action(struct iavf_pattern_match_item *match_item,
                       const struct rte_flow_action actions[],
-                      uint64_t pattern_hint, void **meta,
+                      uint64_t pattern_hint, struct iavf_rss_meta *rss_meta,
                       struct rte_flow_error *error)
  {
-       struct iavf_rss_meta *rss_meta = (struct iavf_rss_meta *)*meta;
        struct virtchnl_proto_hdrs *proto_hdrs;
        enum rte_flow_action_type action_type;
        const struct rte_flow_action_rss *rss;
@@ -1378,7 +1377,7 @@ struct rss_attr_type {
                goto error;

ret = iavf_hash_parse_action(pattern_match_item, actions, phint,

-                                    (void **)&rss_meta_ptr, error);
+                                    rss_meta_ptr, error);

error:

        if (!ret && meta)