05/11/2021 21:39, Thomas Monjalon: > 04/11/2021 11:34, Kai Ji: > > From: Fan Zhang <roy.fan.zh...@intel.com> > > > > This patch replaces the mixed QAT symmetric and asymmetric > > support implementation by separate files with shared or > > individual implementation for specific QAT generation. > > > > Signed-off-by: Arek Kusztal <arkadiuszx.kusz...@intel.com> > > Signed-off-by: Fan Zhang <roy.fan.zh...@intel.com> > > Signed-off-by: Kai Ji <kai...@intel.com> > > Acked-by: Ciara Power <ciara.po...@intel.com> > [...] > > +++ b/drivers/crypto/qat/dev/qat_sym_pmd_gen1.c > > +#include "qat_sym_session.h" > > +#include "qat_sym.h" > > +#include "qat_sym_session.h" > > +#include "qat_crypto.h" > > +#include "qat_crypto_pmd_gens.h" > > I suppose the double include of qat_sym_session.h is useless...
Note: it can be detected with devtools/check-dup-includes.sh Other avoidable issues in this series detected with devtools/check-meson.py: Error: Missing trailing "," in list at drivers/common/qat/meson.build:56 Error parsing drivers/common/qat/meson.build:74, got some tabulation I expect such basic issues to be solved by the component maintainers, or at last, by the tree maintainer. This time I will fix it.
