On Fri, Oct 29, 2021 at 11:53 AM Olivier Matz <olivier.m...@6wind.com> wrote:
>
> Since its introduction in 2018, the SIGBUS handler was never registered,
> and all related functions were unused.
>
> A SIGBUS can be received by the application when accessing to hugepages
> even if mmap() was successful, This happens especially when running
> inside containers when there is not enough hugepages. In this case, we
> need to recover. A similar scheme can be found in eal_memory.c.
>
> Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Olivier Matz <olivier.m...@6wind.com>This patch lgtm. The key point here is that in the "container context" (well, cgroups) mmap succeeds regardless of availability of hugepages. I would put an emphasis about this in the title. What do you think of: mem: fix dynamic hugepage mapping in container -- David Marchand
