On 10/26/2021 4:20 PM, Gregory Etelson wrote:
Testpmd provides 2 sets of flex item create and destroy functions One for hosts with JSON library. These functions parse flex item configuration stored in JSON file and create or destroy flex item object. The second functions set is for hosts without JSON library for compilation compatibility.On hosts without JSON library, current implementation issues "no JSON library" notification on port close. The notification was triggered by port destructors that include flex items flush routine. The patch introduces single implementation for testpmd flex item destroy. Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands") Signed-off-by: Gregory Etelson<getel...@nvidia.com> --- app/test-pmd/cmd_flex_item.c | 72 ++++++++++++++++++------------------
Hi Gregory, Ori, I just recognized that 'cmd_flex_item.c' doesn't have an explicit maintainer, which makes it fallback to Xialyoun, but I don't think that is related to existing coverage. Since the file is related to rte_flow and only user of it (also author of it) is nvidia, can one of you take the maintainership of the file? It is easier to add it to 'Flow API' block in MAINTAINERS file, that Ori already is the maintainer, if that suits. And perhaps, if you guys are OK, Gregory can be added to 'Flow API' too, it is good to have multiple maintainers. Thanks, ferruh
