02/11/2021 19:08, Dmitry Kozlyuk:
> 2021-11-01 17:03 (UTC+0000), Bruce Richardson:
> > Meson 0.60 switched the format of uninstalled static libraries
> > to thin archives, that is, they contain only paths to object files,
> > not the files themselves. Files cannot be extracted in this case,
> > resulting in build errors:
> > 
> >     ar: `x' cannot be used on thin archives.
> > 
> > Handle thin archives when invoking pmdinfogen by directly using the
> > files referenced in the archive, when they already exist, and extracting
> > them if not.
> > 
> > Bugzilla ID: 836
> > Fixes: e6e9730c7066 ("buildtools: support object file extraction for 
> > Windows")
> > Cc: sta...@dpdk.org
> > 
> > Reported-by: Michal Berger <michallinuxst...@gmail.com>
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozl...@gmail.com>
> > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
> 
> LGTM.
> Note: meson 0.60 can't build DPDK on Windows due to a meson bug,
> but *.pmd.c generation stage passes OK.

Should we add this comment in the commit log?
Knowing that Windows build is broken looks to be an interesting info.
Should we add a known issue in the release notes?


Reply via email to