On Mon, Nov 1, 2021 at 8:32 PM Ferruh Yigit <ferruh.yi...@intel.com> wrote:
>
> On 10/22/2021 12:56 PM, Tomasz Duszynski wrote:
> > Add initial support for baseband telemetry.
> >
> > Signed-off-by: Tomasz Duszynski<tduszyn...@marvell.com>
> > ---
> > v2:
> > - make bphy telemetry available only on platforms supporting baseband
> > - use platform types where possible
> > - remove unused header
> >
> >   drivers/common/cnxk/cnxk_telemetry_bphy.c | 52 +++++++++++++++++++++++
>
> Since the telemetry support is for 'raw/cnxk_bphy', why it is implemented
> in common code, instead of driver?

It can be raw/cnxk_bphy, thought of keeping it in common due to
1) To reuse it for another common code consumer
2) roc_bphy_sso_pf_func_get() and roc_bphy_npa_pf_func_get() manged by
common code. aka there is no reverse dependency on the raw driver framework
in common code.

>
> >   drivers/common/cnxk/meson.build           |  3 +-
> >   drivers/common/cnxk/roc_model.h           |  5 +++
> >   drivers/raw/cnxk_bphy/cnxk_bphy.c         | 11 +++++
> >   drivers/raw/cnxk_bphy/cnxk_bphy_irq.h     |  1 +
> >   5 files changed, 71 insertions(+), 1 deletion(-)
> >   create mode 100644 drivers/common/cnxk/cnxk_telemetry_bphy.c
>

Reply via email to