On Wed, Oct 27, 2021 at 5:21 AM Min Hu (Connor) <humi...@huawei.com> wrote: > > Hi, David, > In function "bond_ethdev_promiscuous_disable", > for "ROUND ROBIN","BALANCE","BROADCAST","8023AD" mode, Promiscuous mode > is propagated to all slaves. > > While for "ACTIVE_BACKUP", "TLB", "ALB", promiscuous mode is propagated > only to primary slave. > > Why?
>From what I remember of the rework I did some time ago, the code was already doing it and I did not question it. I guess it mimicks what the Linux kernel bonding driver does. > > The second question, for "ACTIVE_BACKUP", when primary active slave > fails, a different slave becomes active, does the promiscuous mode state > of former primary should be set to the new primary? IOW, setting promisc on the link that becomes primary? If it is not done, it sounds like a bug. -- David Marchand
