Hi, > -----Original Message----- > From: Yigit, Ferruh <ferruh.yi...@intel.com> > Sent: Friday, October 22, 2021 12:51 AM > To: Li, Miao <miao...@intel.com>; dev@dpdk.org > Cc: Xia, Chenbo <chenbo....@intel.com>; maxime.coque...@redhat.com > Subject: Re: [dpdk-dev] [PATCH v7 1/5] net/virtio: implement > rte_power_monitor API > > On 10/18/2021 3:16 PM, Miao Li wrote: > > This patch implements rte_power_monitor API in virtio PMD to reduce > > Hi Miao, > > If there will be a new version can you please drop the "This patch implements" > part, you can directly start explaining what patch does.
I will remove this part in the next version. Thanks, Miao > > > power consumption when no packet come in. According to current semantics > > of power monitor, this commit adds a callback function to decide whether > > aborts the sleep by checking current value against the expected value and > > virtio_get_monitor_addr to provide address to monitor. When no packet > come > > in, the value of address will not be changed and the running core will > > sleep. Once packets arrive, the value of address will be changed and the > > running core will wakeup. > > > > Signed-off-by: Miao Li<miao...@intel.com> > > Reviewed-by: Chenbo Xia<chenbo....@intel.com> > > > <...>
