On 10/19/21 11:47 AM, David Marchand wrote: > On Mon, Oct 18, 2021 at 4:49 PM Andrew Rybchenko > <andrew.rybche...@oktetlabs.ru> wrote: >> >> Add RTE_ prefix to internal API defined in public header. >> Use the prefix instead of double underscore. >> Use uppercase for macros in the case of name conflict. > > Fwiw, I see no use out of dpdk for those helpers/macros. > > $ git grep-all -E > '\<(__MEMPOOL_STAT_ADD|__mempool_contig_blocks_check_cookies|__mempool_check_cookies|__mempool_generic_get|__mempool_generic_put|__mempool_get_trailer|__mempool_get_header)\>' > > Not a review, just something that caught my eye below: > > [snip] > >> @@ -1384,7 +1385,7 @@ rte_mempool_put_bulk(struct rte_mempool *mp, void * >> const *obj_table, >> struct rte_mempool_cache *cache; >> cache = rte_mempool_default_cache(mp, rte_lcore_id()); >> rte_mempool_trace_put_bulk(mp, obj_table, n, cache); >> - rte_mempool_generic_put(mp, obj_table, n, cache); >> + rte_mempool_do_generic_put(mp, obj_table, n, cache); > > Is this change expected?
My bad. Many thanks for very careful review. Will fix in v2. > > >> } >> >> /** > > [snip] > > >> @@ -1541,7 +1542,7 @@ rte_mempool_get_bulk(struct rte_mempool *mp, void >> **obj_table, unsigned int n) >> struct rte_mempool_cache *cache; >> cache = rte_mempool_default_cache(mp, rte_lcore_id()); >> rte_mempool_trace_get_bulk(mp, obj_table, n, cache); >> - return rte_mempool_generic_get(mp, obj_table, n, cache); >> + return rte_mempool_do_generic_get(mp, obj_table, n, cache); >> } >> >> /** > > Idem. Same here.
