> -----Original Message----- > From: Olivier Matz <olivier.m...@6wind.com> > Sent: Friday, October 15, 2021 8:58 PM > To: Peng, ZhihongX <zhihongx.p...@intel.com> > Cc: dmitry.kozl...@gmail.com; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v4 1/2] lib/cmdline: release cl when cmdline exit > > On Wed, Oct 13, 2021 at 01:52:22AM +0000, zhihongx.p...@intel.com wrote: > > From: Zhihong Peng <zhihongx.p...@intel.com> > > > > Malloc cl in the cmdline_stdin_new function, so release in the > > cmdline_stdin_exit function is logical, so that cl will not be > > released alone. > > > > Fixes: af75078fece3 ("first public release") > > Cc: sta...@dpdk.org > > As said by Dmitry, we should not backport this fix to avoid breaking external > apps.
The v5 version will be fixed. > > Signed-off-by: Zhihong Peng <zhihongx.p...@intel.com> > > I suggest to merge the 2 patches in one, because the second is mandatory > when the first one is applied. The v5 version will be fixed > Thanks Zhihong, and thanks Dmitry for the previous review.