Hello Ferruh, ..snip..
> > testpmd> flow flex_item create <port> > <flex_id> <filename> > > > > The file here is .json file, right? What do you > think to provide some > sample .json file? I am not quite sure though > where can be a place for > them, perhaps a sub-folder under testpmd? > JSON file example will be added in patch update. Flex item configuration is not part of testpmd infrastructure. It belongs to run-time test environment. It should not be treated differently than file parameter for the `load` testpmd command. ..snip.. > > What do you think to decouple json & flex item > support a little more? > > > Like: > flex_item_config(&fp->flex_conf); > flex_item_config_json(&fp->flex_conf); > jroot = json_load_file() > parse json & fill flex_conf > json_decref(jroot); > > [1]. ..snip.. > > Does it make sense to move all above code (ifdef > block) to a separate file? > > Just because 'cmdline_flow.c' is getting bigger, I > want to get your comment, > no strong opinion. [2]. [1], [2] - I'll update the code in upcoming patch Regards, Gregory
