Hello Ferruh,
> On 10/14/2021 9:37 AM, Thomas Monjalon
> wrote:
> > 13/10/2021 19:13, Gregory Etelson:
> >> IPv4 header encodes fragment information
> into 16 bits field.
> >> 3 bits hold flags and remaining 13 bits are for
> fragment offset.
> >> 13 bits bit-field cannot be defined both for big
> and little endian
> >> systems.
> >>
> >> The patch removes IPv4 fragments union
> announce.
> >>
> >> Fixes: f7383e7c7ec1 ("net: announce changes
> in IPv4 header access")
> >>
> >> Signed-off-by: Gregory Etelson
> <getel...@nvidia.com>
> >
> > OK to drop this announce.
> > There is no implementation anyway,
> > it will be back in one year if there is a solution.
> >
>
> If there is an option to have it back, why not
> keep it in the deprecation
> notice, this ensures we won't forgot it.
>
It doesn't look that 3/13 bits split can be implemented as
#if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
/* LE bit-fields */
# elif RTE_BYTE_ORDER == RTE_BIG_ENDIAN
/* BE bit-fields */
#endif
The minimal bits ratio for that option is 4/12.
> > Acked-by: Thomas Monjalon
> <tho...@monjalon.net>
> >
> >
