Hi Li,
The commit message is not compliant with the contributors guidelines:
https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line
On 9/3/21 10:02, Li Feng wrote:
Vhost-user client must send the mem table, kick fd, call fd on all
virtqueues, then the device will be VIRTIO_DEV_RUNNING.
If the vhost-user communication is initialized partly, e.g.
- When initializing the vhost-user, try to restart the vhost-user
backend;
- Seabios only initialized the vhost-scsi req vq.
The device is not with flags VIRTIO_DEV_RUNNING..
Root Cause:
The vhost session has been created, and added the scsi/blk requestq
poller into reactor, but when destroying the device, the requestq is not
unregistered.
Reproduce the crash on spdk vhost-user backend:
1. Create a VM;
2. Mount a ISO to a VM, start the VM, don't install the OS;
3. Restart the spdk_tgt;
Another discusstion is in seabiso:
https://patchew.org/Seabios/20210831122339.2591585-1-fen...@smartx.com/
This is a fix, so you need to add the Fixes tag and cc stable.
Signed-off-by: Li Feng <fen...@smartx.com>
---
v2:
Fix the commit msg typo: vas -> virtqueues.
--
lib/vhost/vhost.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
index 355ff37651..191ba82c41 100644
--- a/lib/vhost/vhost.c
+++ b/lib/vhost/vhost.c
@@ -710,8 +710,8 @@ vhost_destroy_device_notify(struct virtio_net *dev)
if (vdpa_dev)
vdpa_dev->ops->dev_close(dev->vid);
dev->flags &= ~VIRTIO_DEV_RUNNING;
- dev->notify_ops->destroy_device(dev->vid);
}
+ dev->notify_ops->destroy_device(dev->vid);
.destroy_device() is the counter-part of .new_device().
VIRTIO_DEV_RUNNING is set only when .new_device() has been called with
success, and cleared when .destroy_device() is called.
So I disagree with the fix, we want to keep the correlation between
VIRTIO_DEV_RUNNING and .new_device()/.destroy_device(). Doing otherwise
could lead to regressions with other applications than yours.
What is not clear from the commit message or the discussion you link is
where does it crash exactly. Is it in SPDK, in DPDK?
Regards,
Maxime
}
/*
