The driver may change offloads info into dev->data->dev_conf in dev_configure which may cause apps use outdated values.
Add a new API to get actual device configuration. Acked-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> Signed-off-by: Jie Wang <jie1x.w...@intel.com> --- doc/guides/rel_notes/release_21_11.rst | 4 ++++ lib/ethdev/rte_ethdev.c | 20 ++++++++++++++++++++ lib/ethdev/rte_ethdev.h | 18 ++++++++++++++++++ lib/ethdev/version.map | 1 + 4 files changed, 43 insertions(+) diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index d5c762df62..5292149981 100644 --- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst @@ -81,6 +81,10 @@ New Features * Default VLAN strip behavior was changed. VLAN tag won't be stripped unless ``DEV_RX_OFFLOAD_VLAN_STRIP`` offload is enabled. +* **Added support for users get device configuration in ethdev.** + + Added an ethdev API which can help users get device configuration. + * **Updated AF_XDP PMD.** * Disabled secondary process support. diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 5fae7357c8..063e4925f8 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -3437,6 +3437,26 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info) return 0; } +int +rte_eth_dev_conf_get(uint16_t port_id, struct rte_eth_conf *dev_conf) +{ + struct rte_eth_dev *dev; + + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); + dev = &rte_eth_devices[port_id]; + + if (dev_conf == NULL) { + RTE_ETHDEV_LOG(ERR, + "Cannot get ethdev port %u configuration to NULL\n", + port_id); + return -EINVAL; + } + + memcpy(dev_conf, &dev->data->dev_conf, sizeof(struct rte_eth_conf)); + + return 0; +} + int rte_eth_dev_get_supported_ptypes(uint16_t port_id, uint32_t ptype_mask, uint32_t *ptypes, int num) diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index cb847a2c38..58d10e5699 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h @@ -3052,6 +3052,24 @@ int rte_eth_macaddr_get(uint16_t port_id, struct rte_ether_addr *mac_addr); */ int rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info); +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Retrieve the configuration of an Ethernet device. + * + * @param port_id + * The port identifier of the Ethernet device. + * @param dev_conf + * Location for Ethernet device configuration to be filled in. + * @return + * - (0) if successful. + * - (-ENODEV) if *port_id* invalid. + * - (-EINVAL) if bad parameter. + */ +__rte_experimental +int rte_eth_dev_conf_get(uint16_t port_id, struct rte_eth_conf *dev_conf); + /** * Retrieve the firmware version of a device. * diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map index 29fb71f1af..4debda513b 100644 --- a/lib/ethdev/version.map +++ b/lib/ethdev/version.map @@ -247,6 +247,7 @@ EXPERIMENTAL { rte_mtr_meter_policy_validate; # added in 21.11 + rte_eth_dev_conf_get; rte_eth_rx_metadata_negotiate; }; -- 2.25.1