14/10/2021 10:25, Bruce Richardson: > On Thu, Oct 14, 2021 at 04:54:19AM +0800, Kefu Chai wrote: > > RTE_MAX_MEMSEG_LISTS = 128 is not enough for many-core machines, in our > > case, we need to increase it to 8192. so add an option so user can > > override it. > > > > Signed-off-by: Kefu Chai <tchai...@gmail.com> > > This seems a very low-level option to be exposing to the user. Some > thoughts/questions: > > - can you give some more detail on why you need such a massive number, 64 > times the default? > - what would be the impact of increasing the default to 8192? I assume this > is only used in a few places in EAL, so would the memory footprint > increase be large? > - rather than a single specified value, would an alternative be to make > this be a computed value at config time, scaled by number of lcores (or > number of numa nodes)?
+1 for these suggestions
