27/09/2021 17:03, kefu chai: > On Mon, Sep 20, 2021 at 4:08 PM Bruce Richardson > <bruce.richard...@intel.com> wrote: > > > > On Mon, Sep 20, 2021 at 03:51:06PM +0800, kefu chai wrote: > > > hello Bruce, > > > > > > do you have any further concerns? is there anything i can do to move > > > this forward? > > > > > > cheers, > > > > > > > +Anatoly, for his input for the memory segments change. > > > > I still would prefer not to have these as config options, but perhaps one > > or both needs to be. The atomic refcount seems more reasonable to add of > > the two. For the max memseg lists, what is the impact if we were to > > increase this value globally? > > hi Bruce, thank you for your insights. > > yeah, as i explained in the previous email.the atomic refcount is more > critical for my work on integration of DPDK+SPDK+Seastar. since > Seastar enforces share-nothing in its design, there is no need to use > atomic refcount under almost all circumstances. regarding to the max > memseg list, what i am trying is to port the change of > https://github.com/scylladb/seastar/commit/716c7c04db693c266f52de6b0cced0252d70b3bf > to the DPDK used by the latest release of SPDK.
I think it would help acceptance to send these changes as 2 separate patches.
