On 12/10/2021 21:34, Dumitrescu, Cristian wrote:
>
>
>> -----Original Message-----
>> From: Singh, Jasvinder <jasvinder.si...@intel.com>
>> Sent: Wednesday, September 1, 2021 1:20 PM
>> To: dev@dpdk.org
>> Cc: Dumitrescu, Cristian <cristian.dumitre...@intel.com>; m...@ashroe.eu;
>> Zhang, Roy Fan <roy.fan.zh...@intel.com>
>> Subject: [PATCH] pipeline: remove experimental tag from API
>>
>> These APIs were introduced in 18.05, therefore removing
>> experimental tag to promote them to stable state.
>>
>> Signed-off-by: Jasvinder Singh <jasvinder.si...@intel.com>
>> ---
>> lib/pipeline/rte_port_in_action.h | 10 ----------
>> lib/pipeline/rte_table_action.h | 18 ------------------
>> lib/pipeline/version.map | 16 ++++++----------
>> 3 files changed, 6 insertions(+), 38 deletions(-)
>>
>> diff --git a/lib/pipeline/rte_port_in_action.h
>> b/lib/pipeline/rte_port_in_action.h
>> index d6b063cf58..de611cbfab 100644
>> --- a/lib/pipeline/rte_port_in_action.h
>> +++ b/lib/pipeline/rte_port_in_action.h
>> @@ -42,8 +42,6 @@
>> * used by the input port action handler based on given action
>> parameters.
>> * API functions: rte_port_in_action_apply().
>> *
>> - * @warning
>> - * @b EXPERIMENTAL: this API may change without prior notice
>> */
>>
>> #ifdef __cplusplus
>> @@ -172,7 +170,6 @@ struct rte_port_in_action_profile;
>> * @return
>> * Input port action profile handle on success, NULL otherwise.
>> */
>> -__rte_experimental
>> struct rte_port_in_action_profile *
>> rte_port_in_action_profile_create(uint32_t socket_id);
>>
>> @@ -184,7 +181,6 @@ rte_port_in_action_profile_create(uint32_t
>> socket_id);
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_port_in_action_profile_free(struct rte_port_in_action_profile *profile);
>>
>> @@ -203,7 +199,6 @@ rte_port_in_action_profile_free(struct
>> rte_port_in_action_profile *profile);
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_port_in_action_profile_action_register(
>> struct rte_port_in_action_profile *profile,
>> @@ -226,7 +221,6 @@ rte_port_in_action_profile_action_register(
>> *
>> * @see rte_port_in_action_create()
>> */
>> -__rte_experimental
>> int
>> rte_port_in_action_profile_freeze(struct rte_port_in_action_profile
>> *profile);
>>
>> @@ -249,7 +243,6 @@ struct rte_port_in_action;
>> * @return
>> * Handle to input port action object on success, NULL on error.
>> */
>> -__rte_experimental
>> struct rte_port_in_action *
>> rte_port_in_action_create(struct rte_port_in_action_profile *profile,
>> uint32_t socket_id);
>> @@ -262,7 +255,6 @@ rte_port_in_action_create(struct
>> rte_port_in_action_profile *profile,
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_port_in_action_free(struct rte_port_in_action *action);
>>
>> @@ -276,7 +268,6 @@ rte_port_in_action_free(struct rte_port_in_action
>> *action);
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_port_in_action_params_get(struct rte_port_in_action *action,
>> struct rte_pipeline_port_in_params *params);
>> @@ -296,7 +287,6 @@ rte_port_in_action_params_get(struct
>> rte_port_in_action *action,
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_port_in_action_apply(struct rte_port_in_action *action,
>> enum rte_port_in_action_type type,
>> diff --git a/lib/pipeline/rte_table_action.h
>> b/lib/pipeline/rte_table_action.h
>> index 82bc9d9ac9..aac6b8ce8d 100644
>> --- a/lib/pipeline/rte_table_action.h
>> +++ b/lib/pipeline/rte_table_action.h
>> @@ -48,8 +48,6 @@
>> * - Use the table action object to read action data (e.g. stats counters)
>> for
>> * any given rule. API functions: rte_table_action_XYZ_read().
>> *
>> - * @warning
>> - * @b EXPERIMENTAL: this API may change without prior notice
>> */
>>
>> #ifdef __cplusplus
>> @@ -823,7 +821,6 @@ struct rte_table_action_profile;
>> * @return
>> * Table action profile handle on success, NULL otherwise.
>> */
>> -__rte_experimental
>> struct rte_table_action_profile *
>> rte_table_action_profile_create(struct rte_table_action_common_config
>> *common);
>>
>> @@ -835,7 +832,6 @@ rte_table_action_profile_create(struct
>> rte_table_action_common_config *common);
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_table_action_profile_free(struct rte_table_action_profile *profile);
>>
>> @@ -854,7 +850,6 @@ rte_table_action_profile_free(struct
>> rte_table_action_profile *profile);
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_table_action_profile_action_register(struct rte_table_action_profile
>> *profile,
>> enum rte_table_action_type type,
>> @@ -875,7 +870,6 @@ rte_table_action_profile_action_register(struct
>> rte_table_action_profile *profil
>> *
>> * @see rte_table_action_create()
>> */
>> -__rte_experimental
>> int
>> rte_table_action_profile_freeze(struct rte_table_action_profile *profile);
>>
>> @@ -899,7 +893,6 @@ struct rte_table_action;
>> *
>> * @see rte_table_action_create()
>> */
>> -__rte_experimental
>> struct rte_table_action *
>> rte_table_action_create(struct rte_table_action_profile *profile,
>> uint32_t socket_id);
>> @@ -912,7 +905,6 @@ rte_table_action_create(struct
>> rte_table_action_profile *profile,
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_table_action_free(struct rte_table_action *action);
>>
>> @@ -926,7 +918,6 @@ rte_table_action_free(struct rte_table_action
>> *action);
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_table_action_table_params_get(struct rte_table_action *action,
>> struct rte_pipeline_table_params *params);
>> @@ -949,7 +940,6 @@ rte_table_action_table_params_get(struct
>> rte_table_action *action,
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_table_action_apply(struct rte_table_action *action,
>> void *data,
>> @@ -969,7 +959,6 @@ rte_table_action_apply(struct rte_table_action
>> *action,
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_table_action_dscp_table_update(struct rte_table_action *action,
>> uint64_t dscp_mask,
>> @@ -989,7 +978,6 @@ rte_table_action_dscp_table_update(struct
>> rte_table_action *action,
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_table_action_meter_profile_add(struct rte_table_action *action,
>> uint32_t meter_profile_id,
>> @@ -1006,7 +994,6 @@ rte_table_action_meter_profile_add(struct
>> rte_table_action *action,
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_table_action_meter_profile_delete(struct rte_table_action *action,
>> uint32_t meter_profile_id);
>> @@ -1038,7 +1025,6 @@ rte_table_action_meter_profile_delete(struct
>> rte_table_action *action,
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_table_action_meter_read(struct rte_table_action *action,
>> void *data,
>> @@ -1065,7 +1051,6 @@ rte_table_action_meter_read(struct
>> rte_table_action *action,
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_table_action_ttl_read(struct rte_table_action *action,
>> void *data,
>> @@ -1091,7 +1076,6 @@ rte_table_action_ttl_read(struct rte_table_action
>> *action,
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_table_action_stats_read(struct rte_table_action *action,
>> void *data,
>> @@ -1112,7 +1096,6 @@ rte_table_action_stats_read(struct
>> rte_table_action *action,
>> * @return
>> * Zero on success, non-zero error code otherwise.
>> */
>> -__rte_experimental
>> int
>> rte_table_action_time_read(struct rte_table_action *action,
>> void *data,
>> @@ -1128,7 +1111,6 @@ rte_table_action_time_read(struct
>> rte_table_action *action,
>> * @return
>> * The pointer to the session on success, NULL otherwise.
>> */
>> -__rte_experimental
>> struct rte_cryptodev_sym_session *
>> rte_table_action_crypto_sym_session_get(struct rte_table_action *action,
>> void *data);
>> diff --git a/lib/pipeline/version.map b/lib/pipeline/version.map
>> index 2b68f584a4..5732fac16b 100644
>> --- a/lib/pipeline/version.map
>> +++ b/lib/pipeline/version.map
>> @@ -24,14 +24,6 @@ DPDK_22 {
>> rte_pipeline_table_entry_delete;
>> rte_pipeline_table_entry_delete_bulk;
>> rte_pipeline_table_stats_read;
>> -
>> - local: *;
>> -};
>> -
>> -EXPERIMENTAL {
>> - global:
>> -
>> - # added in 18.05
>> rte_port_in_action_apply;
>> rte_port_in_action_create;
>> rte_port_in_action_free;
>> @@ -55,10 +47,14 @@ EXPERIMENTAL {
>> rte_table_action_table_params_get;
>> rte_table_action_time_read;
>> rte_table_action_ttl_read;
>> -
>> - # added in 18.11
>> rte_table_action_crypto_sym_session_get;
>>
>> + local: *;
>> +};
>> +
>> +EXPERIMENTAL {
>> + global:
>> +
>> # added in 20.11
>> rte_swx_ctl_action_arg_info_get;
>> rte_swx_ctl_action_info_get;
>> --
>> 2.26.3
>
> Acked-by: Cristian Dumitrescu <cristian.dumitre...@intel.com>
>
Acked-by: Ray Kinsella <m...@ashroe.eu>
