> > On 10/7/21 2:27 PM, Konstantin Ananyev wrote: > > Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related > > data into private header (ethdev_driver.h). > > Few minor changes to keep DPDK building after that. > > > > Signed-off-by: Konstantin Ananyev <konstantin.anan...@intel.com> > > [snip] > > I realize that many notes below correspond to just > moved code, but I still think that ti would be nice > to fix anyway.
Yes, that’s just cut and paste from rte_ethdev_core.h and ethdev_driver.h It is probably a good idea to clean-up and might be re-layout rte_eth_dev and friends, but I don't think it has to be part of this patch-set. After all, if it will become internal structure, that work could be done for any DPDK release.