From: Shahaji Bhosle <sbho...@broadcom.com>
Fix an error reported during CLANG compilation.
-Wtautological-constant-out-of-range-compare for enums
$ export CC=clang
$ meson --werror --buildtype=debugoptimized build && ninja-build -C build
"
[..]
../../root/dpdk/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c:140:18: error:
comparison of constant 2147483648 with expression of type 'const enum
rte_flow_item_type' is always false
[-Werror,-Wtautological-constant-out-of-range-compare]
if (item->type >= (uint32_t)
~~~~~~~~~~ ^ ~~~~~~~~~~
../../root/dpdk/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c:142:19: error:
comparison of constant 2147483650 with expression of type 'const enum
rte_flow_item_type' is always false
[-Werror,-Wtautological-constant-out-of-range-compare]
if (item->type >=
~~~~~~~~~~ ^
../../root/dpdk/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c:188:25: error:
comparison of constant 2147483648 with expression of type 'const enum
rte_flow_action_type' is always false
[-Werror,-Wtautological-constant-out-of-range-compare]
if (action_item->type >=
~~~~~~~~~~~~~~~~~ ^
../../root/dpdk/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c:190:26: error:
comparison of constant 2147483650 with expression of type 'const enum
rte_flow_action_type' is always false
[-Werror,-Wtautological-constant-out-of-range-compare]
if (action_item->type >=
~~~~~~~~~~~~~~~~~ ^
4 errors generated.
"
Bugzilla ID: 821
Fixes: bdf4a3c6316b ("net/bnxt: support tunnel offload")
Signed-off-by: Shahaji Bhosle <sbho...@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khapa...@broadcom.com>
---
drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c
b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c
index 3a9c9bba27..b589f2281e 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c
@@ -137,9 +137,9 @@ bnxt_ulp_rte_parser_hdr_parse(const struct rte_flow_item
pattern[],
/* Parse all the items in the pattern */
while (item && item->type != RTE_FLOW_ITEM_TYPE_END) {
- if (item->type >= (uint32_t)
- BNXT_RTE_FLOW_ITEM_TYPE_END) {
- if (item->type >=
+ if ((uint32_t)item->type >=
+ (uint32_t)BNXT_RTE_FLOW_ITEM_TYPE_END) {
+ if ((uint32_t)item->type >=
(uint32_t)BNXT_RTE_FLOW_ITEM_TYPE_LAST)
goto hdr_parser_error;
/* get the header information */
@@ -185,9 +185,9 @@ bnxt_ulp_rte_parser_act_parse(const struct rte_flow_action
actions[],
/* Parse all the items in the pattern */
while (action_item && action_item->type != RTE_FLOW_ACTION_TYPE_END) {
- if (action_item->type >=
+ if ((uint32_t)action_item->type >=
(uint32_t)BNXT_RTE_FLOW_ACTION_TYPE_END) {
- if (action_item->type >=
+ if ((uint32_t)action_item->type >=
(uint32_t)BNXT_RTE_FLOW_ACTION_TYPE_LAST)
goto act_parser_error;
/* get the header information from bnxt actinfo table */
--
2.30.1 (Apple Git-130)
