08/10/2021 09:02, Min Hu (Connor): > Hi, Thomas, > > 在 2021/10/6 3:21, Thomas Monjalon 写道: > > 22/09/2021 05:36, Min Hu (Connor): > >> From: Huisong Li <lihuis...@huawei.com> > >> > >> Use the testpmd to perform the following operations: > >> 1) mac_addr add 0 00:18:2D:00:00:90 > >> 2) mac_addr add 0 00:18:2D:00:00:91 > >> 3) mac_addr add 0 00:18:2D:00:00:92 > >> 4) mac_addr set 0 00:18:2D:00:00:91 > >> 5) show port 0 macs > >> Number of MAC address added: 4 > >> 00:18:2D:00:00:91 > >> 00:18:2D:00:00:90 > >> 00:18:2D:00:00:91 > >> 00:18:2D:00:00:92 > > > > Please describe with words. > > Reading similar MAC addresses is not a fun game. > > I do not catch you, could you please be > more detailed, thanks.
Me too, I don't catch you. Please explain the problem in the commit log so we can understand without the example. > >> This is due to the reason that if the address has been added as a > >> non-default MAC address by rte_eth_dev_mac_addr_add API, it doesn't remove > >> from dev->data->mac_addrs[] when set default MAC address with the same > >> address. > >> > >> Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier") > >> Cc: sta...@dpdk.org > >> > >> Signed-off-by: Huisong Li <lihuis...@huawei.com> > >> Signed-off-by: Min Hu (Connor) <humi...@huawei.com>