Please don't apply this patch. I think we're waiting for meson to fix it. https://github.com/mesonbuild/meson/issues/9296
In the meantime, at OVS's meson build script, I'm adding /WHOLEARCHIVE and /FORCE:MULTIPLE when linking dpdk. So no need to fix it here. Thanks William On Thu, Oct 7, 2021 at 4:58 AM Thomas Monjalon <tho...@monjalon.net> wrote: > > Hi, > > What is the conclusion for this patch? > > 26/09/2021 05:22, William Tu: > > On Sat, Sep 25, 2021 at 9:22 AM Dmitry Kozlyuk <dmitry.kozl...@gmail.com> > > wrote: > > > > > > 2021-09-24 18:08 (UTC+0000), William Tu: > > > > Windows does not support linker option '/-no-whole-archive' > > > > or '/whole-archive'. The patch removes them under Windows build. > > > > > > > > Signed-off-by: William Tu <u9012...@gmail.com> > > > > --- > > > > buildtools/pkg-config/meson.build | 10 +++++++--- > > > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > > > Hi William, > > > > > > We need to tell the linker to use whole archive somehow; > > > you write [1] that /WHOLEARCHIVE was required in the end. > > > There's no "Windows linker", there are clang and GCC linkers, > > > the latter supports --whole-archive, but the former needs it translated. > > > Argument translation between compilers is handled by meson. > > > I've filed a bug: https://github.com/mesonbuild/meson/issues/9296 > > > > > > [1]: > > > http://inbox.dpdk.org/dev/CALDO+SZ-FLPYNQbUJ-Ctwtph+M4_X_=zyaokgkp5_un4qfq...@mail.gmail.com/ > > > > Hi Dmitry, > > > > Thank you! > > One more thing, when I added /WHOLEARCHIVE, I hit some errors due to > > macro definitions. > > ex: > > ws2_32.lib(WS2_32.dll) : error LNK2005: WS2_32_NULL_THUNK_DATA already > > defined in mincore.lib(WS2_32.dll) > > Shlwapi.lib(SHLWAPI.dll) : error LNK2005: __NULL_IMPORT_DESCRIPTOR > > already defined in mincore.lib(api-ms-win-core > > -com-l1-1-0.dll) > > Iphlpapi.lib(IPHLPAPI.DLL) : error LNK2005: > > __IMPORT_DESCRIPTOR_IPHLPAPI already defined in mincore.lib(IPHLPAPI. > > see: > > https://github.com/smadaminov/ovs-dpdk-meson-issues/issues/65 > > > > In the end, I have to add also: > > -Wl,/FORCE:MULTIPLE > > > > Thanks > > William > > > >
