Hi Gowrishankar, >-----Original Message----- >From: Gowrishankar Muthukrishnan <gmuthukri...@marvell.com> >Sent: Thursday 30 September 2021 10:01 >To: Power, Ciara <ciara.po...@intel.com>; dev@dpdk.org >Cc: Richardson, Bruce <bruce.richard...@intel.com> >Subject: RE: [v2] telemetry: fix json output buffer size > >> >Also, I propose if we can have platform defined upper limits (esp >> >MAX_CMD_LEN, MAX_SINGLE_STRING_LEN etc) so that, we need not revisit >> >lib/telemetry for platform needs (and I don't think one size fits all >> >platform, may be excess too). >> >Thoughts ? >> >> I am not sure why it is needed to have limits defined per platform - >> can you explain further about why it is necessary? >> > >Mainly, for the endpoint in driver. In case, if the endpoint data is bigger >than >MAX_SINGLE_STRING_LEN at the worst case, endpoint will not work correctly. >
The MAX_SINGLE_STRING_LEN is currently 8192 - if a value is turning out to be bigger than that, maybe we should be looking at why the string is that long and if it needs to be - i.e. could it be broken down to be more consumable rather than modifying the lib to accept an extremely long string. I don't see an issue with increasing the MAX_CMD_LEN a little in the lib - although it is currently 56, it probably doesn't need to be a huge increase, commands are easier used when concise. Not sure having platform specific values here is necessary. Thanks, Ciara >Thanks, >Gowrishankar
