Hello Pavan, Ray, On Wed, Oct 6, 2021 at 8:52 AM <pbhagavat...@marvell.com> wrote: > > From: Pavan Nikhilesh <pbhagavat...@marvell.com> > > Mark rte_trace global variables as internal i.e. remove them > from experimental section of version map. > Some of them are used in inline APIs, mark those as global. > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@marvell.com> > Acked-by: Ray Kinsella <m...@ashroe.eu>
Please, sort those symbols. I check with ./devtools/update-abi.sh $(cat ABI_VERSION) > --- > lib/eventdev/version.map | 77 ++++++++++++++++++---------------------- > 1 file changed, 35 insertions(+), 42 deletions(-) > > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map > index 068d186c66..617fff0ae6 100644 > --- a/lib/eventdev/version.map > +++ b/lib/eventdev/version.map > @@ -88,57 +88,19 @@ DPDK_22 { > rte_event_vector_pool_create; > rte_eventdevs; > > - #added in 21.11 > - rte_event_fp_ops; > - > - local: *; > -}; > - > -EXPERIMENTAL { > - global: > - > # added in 20.05 At the next ABI bump, ./devtools/update-abi.sh will strip those comments from the stable section. You can notice this when you run ./devtools/update-abi.sh $CURRENT_ABI as suggested above. I would strip the comments now that the symbols are going to stable. Ray, do you have an opinion? -- David Marchand