Hi Joyce,
On Sun, Aug 22, 2021 at 10:20:34PM -0500, Joyce Kong wrote:
> In stack module, remove the duplicated header file rte_atomic.h
> as it has been included in rte_spinlock.h/rte_pause.h
>
> Signed-off-by: Joyce Kong <joyce.k...@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com>
Sorry for the late feedback.
No objection about the patch itself, but I don't think the commit log
should say that rte_atomic.h is indirectly included by
rte_spinlock.h/rte_pause.h.
To me, it is not a good reason to remove an include. However, it looks
that no function from rte_atomic.h is used in these files, especially
since commit c51e67c2ee18 ("test/stack: remove thread synchronisation")
for the test app.
Thanks,
Olivier
