[dpdk-dev] [PATCH] [v2] vdpa/ifc: increase readability in function

[jilei chen]

Optimize several parameters form order to better readability

Signed-off-by: jilei chen <chenji...@cmss.chinamobile.com>
---
v2:
* Concise subject of the patch
* Optimize function parameters
---
 drivers/vdpa/ifc/ifcvf_vdpa.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
index 1dc813d0a3..365da2a8b9 100644
--- a/drivers/vdpa/ifc/ifcvf_vdpa.c
+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
@@ -182,7 +182,7 @@ ifcvf_vfio_setup(struct ifcvf_internal *internal)
 }
 
 static int
-ifcvf_dma_map(struct ifcvf_internal *internal, int do_map)
+ifcvf_dma_map(struct ifcvf_internal *internal, bool do_map)
 {
        uint32_t i;
        int ret;
@@ -538,11 +538,11 @@ update_datapath(struct ifcvf_internal *internal)
        if (!rte_atomic32_read(&internal->running) &&
            (rte_atomic32_read(&internal->started) &&
             rte_atomic32_read(&internal->dev_attached))) {
-               ret = ifcvf_dma_map(internal, 1);
+               ret = ifcvf_dma_map(internal, true);
                if (ret)
                        goto err;
 
-               ret = vdpa_enable_vfio_intr(internal, 0);
+               ret = vdpa_enable_vfio_intr(internal, false);
                if (ret)
                        goto err;
 
@@ -568,7 +568,7 @@ update_datapath(struct ifcvf_internal *internal)
                if (ret)
                        goto err;
 
-               ret = ifcvf_dma_map(internal, 0);
+               ret = ifcvf_dma_map(internal, false);
                if (ret)
                        goto err;
 
@@ -850,7 +850,7 @@ ifcvf_sw_fallback_switchover(struct ifcvf_internal 
*internal)
                goto error;
 
        /* set up interrupt for interrupt relay */
-       ret = vdpa_enable_vfio_intr(internal, 1);
+       ret = vdpa_enable_vfio_intr(internal, true);
        if (ret)
                goto unmap;
 
@@ -875,7 +875,7 @@ ifcvf_sw_fallback_switchover(struct ifcvf_internal 
*internal)
 unset_intr:
        vdpa_disable_vfio_intr(internal);
 unmap:
-       ifcvf_dma_map(internal, 0);
+       ifcvf_dma_map(internal, false);
 error:
        return -1;
 }
@@ -934,7 +934,7 @@ ifcvf_dev_close(int vid)
                vdpa_disable_vfio_intr(internal);
 
                /* unset DMA map for guest memory */
-               ifcvf_dma_map(internal, 0);
+               ifcvf_dma_map(internal, false);
 
                internal->sw_fallback_running = false;
        } else {
@@ -1130,7 +1130,7 @@ ifcvf_set_vring_state(int vid, int vring, int state)
        }
 
        if (state && !hw->vring[vring].enable) {
-               ret = vdpa_enable_vfio_intr(internal, 0);
+               ret = vdpa_enable_vfio_intr(internal, false);
                if (ret)
                        return ret;
        }
-- 
2.12.2