> -----Original Message-----
> From: Ananyev, Konstantin <konstantin.anan...@intel.com>
> Sent: Wednesday, September 22, 2021 22:10
> To: dev@dpdk.org
> Cc: Li, Xiaoyun <xiaoyun...@intel.com>; ano...@marvell.com;
> jer...@marvell.com;
> ndabilpu...@marvell.com; adwiv...@marvell.com; shepard.sie...@atomicrules.com;
> ed.cz...@atomicrules.com; john.mil...@atomicrules.com; irussk...@marvell.com;
> ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com;
> rahul.lakkire...@chelsio.com;
> hemant.agra...@nxp.com; sachin.sax...@oss.nxp.com; Wang, Haiyue
> <haiyue.w...@intel.com>; Daley, John
> <johnd...@cisco.com>; hyon...@cisco.com; Zhang, Qi Z <qi.z.zh...@intel.com>;
> Wang, Xiao W
> <xiao.w.w...@intel.com>; humi...@huawei.com; yisen.zhu...@huawei.com;
> ouli...@huawei.com; Xing, Beilei
> <beilei.x...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Yang, Qiming
> <qiming.y...@intel.com>;
> ma...@nvidia.com; viachesl...@nvidia.com; sthem...@microsoft.com;
> lon...@microsoft.com;
> heinrich.k...@corigine.com; kirankum...@marvell.com;
> andrew.rybche...@oktetlabs.ru;
> mcze...@marvell.com; jiawe...@trustnetic.com; jianw...@trustnetic.com;
> maxime.coque...@redhat.com; Xia,
> Chenbo <chenbo....@intel.com>; tho...@monjalon.net; Yigit, Ferruh
> <ferruh.yi...@intel.com>;
> m...@ashroe.eu; Jayatheerthan, Jay <jay.jayatheert...@intel.com>; Ananyev,
> Konstantin
> <konstantin.anan...@intel.com>
> Subject: [RFC v2 2/5] ethdev: change input parameters for rx_queue_count
>
> Currently majority of 'fast' ethdev ops take pointers to internal
> queue data structures as an input parameter.
> While eth_rx_queue_count() takes a pointer to rte_eth_dev and queue
> index.
> For future work to hide rte_eth_devices[] and friends it would be
> plausible to unify parameters list of all 'fast' ethdev ops.
> This patch changes eth_rx_queue_count() to accept pointer to internal
> queue data as input parameter.
> This is an API and ABI breakage.
>
> Signed-off-by: Konstantin Ananyev <konstantin.anan...@intel.com>
> ---
> drivers/net/ark/ark_ethdev_rx.c | 4 ++--
> drivers/net/ark/ark_ethdev_rx.h | 3 +--
> drivers/net/atlantic/atl_ethdev.h | 2 +-
> drivers/net/atlantic/atl_rxtx.c | 9 ++-------
> drivers/net/bnxt/bnxt_ethdev.c | 8 +++++---
> drivers/net/dpaa/dpaa_ethdev.c | 9 ++++-----
> drivers/net/dpaa2/dpaa2_ethdev.c | 9 ++++-----
> drivers/net/e1000/e1000_ethdev.h | 6 ++----
> drivers/net/e1000/em_rxtx.c | 4 ++--
> drivers/net/e1000/igb_rxtx.c | 4 ++--
> drivers/net/enic/enic_ethdev.c | 12 ++++++------
> drivers/net/fm10k/fm10k.h | 2 +-
> drivers/net/fm10k/fm10k_rxtx.c | 4 ++--
> drivers/net/hns3/hns3_rxtx.c | 7 +++++--
> drivers/net/hns3/hns3_rxtx.h | 2 +-
> drivers/net/i40e/i40e_rxtx.c | 4 ++--
> drivers/net/i40e/i40e_rxtx.h | 3 +--
> drivers/net/iavf/iavf_rxtx.c | 4 ++--
> drivers/net/iavf/iavf_rxtx.h | 2 +-
> drivers/net/ice/ice_rxtx.c | 4 ++--
> drivers/net/ice/ice_rxtx.h | 2 +-
> drivers/net/igc/igc_txrx.c | 5 ++---
> drivers/net/igc/igc_txrx.h | 3 +--
> drivers/net/ixgbe/ixgbe_ethdev.h | 3 +--
> drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
> drivers/net/mlx5/mlx5_rx.c | 26 ++++++++++++-------------
> drivers/net/mlx5/mlx5_rx.h | 2 +-
> drivers/net/netvsc/hn_rxtx.c | 4 ++--
> drivers/net/netvsc/hn_var.h | 2 +-
> drivers/net/nfp/nfp_rxtx.c | 4 ++--
> drivers/net/nfp/nfp_rxtx.h | 3 +--
> drivers/net/octeontx2/otx2_ethdev.h | 2 +-
> drivers/net/octeontx2/otx2_ethdev_ops.c | 8 ++++----
> drivers/net/sfc/sfc_ethdev.c | 12 ++++++------
> drivers/net/thunderx/nicvf_ethdev.c | 3 +--
> drivers/net/thunderx/nicvf_rxtx.c | 4 ++--
> drivers/net/thunderx/nicvf_rxtx.h | 2 +-
> drivers/net/txgbe/txgbe_ethdev.h | 3 +--
> drivers/net/txgbe/txgbe_rxtx.c | 4 ++--
> drivers/net/vhost/rte_eth_vhost.c | 4 ++--
> lib/ethdev/rte_ethdev.h | 2 +-
> lib/ethdev/rte_ethdev_core.h | 3 +--
> 42 files changed, 97 insertions(+), 110 deletions(-)
>
> diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c
> index d255f0177b..98658ce621 100644
> --- a/drivers/net/ark/ark_ethdev_rx.c
> +++ b/drivers/net/ark/ark_ethdev_rx.c
> @@ -388,11 +388,11 @@ eth_ark_rx_queue_drain(struct ark_rx_queue *queue)
> }
>
> uint32_t
> -eth_ark_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t queue_id)
> +eth_ark_dev_rx_queue_count(void *rx_queue)
> {
> struct ark_rx_queue *queue;
Just change it to be one line : " struct ark_rx_queue *queue = rx_queue;" ?
>
> - queue = dev->data->rx_queues[queue_id];
> + queue = rx_queue;
> return (queue->prod_index - queue->cons_index); /* mod arith */
> }
> --
> 2.26.3
