On Sat, 2021-09-18 at 09:50 +0300, Andrew Rybchenko wrote: > On 9/17/21 5:28 PM, Xueming Li wrote: > > Currently, most ethdev callback API use queue ID as parameter, but Rx > > and Tx queue release callback use queue object which is used by Rx and > > Tx burst data plane callback. > > > > To align with other eth device queue configuration callbacks: > > - queue release callbacks are changed to use queue ID > > - all drivers are adapted > > > > Signed-off-by: Xueming Li <xuemi...@nvidia.com> > > One nit below, other than that ethdev > > Reviewed-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> > > > diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h > > index 40e474aa7e..524757cf6f 100644 > > --- a/lib/ethdev/ethdev_driver.h > > +++ b/lib/ethdev/ethdev_driver.h > > @@ -282,7 +282,8 @@ typedef int (*eth_rx_disable_intr_t)(struct rte_eth_dev > > *dev, > > uint16_t rx_queue_id); > > /**< @internal Disable interrupt of a receive queue of an Ethernet device. > > */ > > > > -typedef void (*eth_queue_release_t)(void *queue); > > +typedef void (*eth_queue_release_t)(struct rte_eth_dev *dev, > > + uint16_t rx_queue_id); > > Since the callback is shared by Rx and Tx, it should not be > rx_queue_id. Just queue_id.
Nice catch! updated in v5. > > > /**< @internal Release memory resources allocated by given RX/TX queue. */ > > > > typedef int (*eth_fw_version_get_t)(struct rte_eth_dev *dev,
