> -----Original Message-----
> From: Chautru, Nicolas <nicolas.chau...@intel.com>
> Sent: Tuesday, September 14, 2021 12:32 AM
> To: Nipun Gupta <nipun.gu...@nxp.com>; dev@dpdk.org; gak...@marvell.com
> Cc: david.march...@redhat.com; Hemant Agrawal <hemant.agra...@nxp.com>
> Subject: RE: [PATCH v5 9/9] app/bbdev: add test vectors for transport blocks
>
>
>
> > -----Original Message-----
> > From: Nipun Gupta <nipun.gu...@nxp.com>
> > Sent: Sunday, September 12, 2021 5:15 AM
> > To: dev@dpdk.org; gak...@marvell.com; Chautru, Nicolas
> > <nicolas.chau...@intel.com>
> > Cc: david.march...@redhat.com; hemant.agra...@nxp.com; Nipun Gupta
> > <nipun.gu...@nxp.com>
> > Subject: [PATCH v5 9/9] app/bbdev: add test vectors for transport blocks
> >
> > This patch adds two test vectors for transport block in network byte
> > order:
> > - LDPC encode for Transport Block
> > - LDPC decode for Transport block
>
> See comments on previous patchsets related to the same topic:
> - This test vector includes Ratematching hence previous pmd exposed
> capability
> were not correct
It is supported in our driver, I will add it in the capabilities.
> - This is really is a single CB vector (not a TB made of multiple CBs). More
> generally I don't believe there is new functionality here compared to existing
> vectors. (keep in mind that the endianness can be managed as a device
> capability and would not require new vectors).
I agree, it is a single CB, otherwise the test vector file becomes large.
But all the TB parameters are supported, which is not the case with the previous
tests.
I prefer to add a bigger test vector with multiple CBs. But then I hear that
file
size is a problem. I don't think it should be a problem. Let me respin with a
larger
size TB.
>
> Thanks
> Nic
>
> >
> > Signed-off-by: Nipun Gupta <nipun.gu...@nxp.com>
> > ---
> > app/test-bbdev/test_vectors/ldpc_dec_tb.data | 122
> > +++++++++++++++++++ app/test-bbdev/test_vectors/ldpc_enc_tb.data |
> > 60 +++++++++
> > 2 files changed, 182 insertions(+)
> > create mode 100644 app/test-bbdev/test_vectors/ldpc_dec_tb.data
> > create mode 100644 app/test-bbdev/test_vectors/ldpc_enc_tb.data
> >
> > diff --git a/app/test-bbdev/test_vectors/ldpc_dec_tb.data b/app/test-
> > bbdev/test_vectors/ldpc_dec_tb.data
> > new file mode 100644
> > index 0000000000..b991e8f305
> > --- /dev/null
> > +++ b/app/test-bbdev/test_vectors/ldpc_dec_tb.data
> > @@ -0,0 +1,122 @@
> > +# SPDX-License-Identifier: BSD-3-Clause # Copyright 2020 NXP
> > +
> > +op_type =
> > +RTE_BBDEV_OP_LDPC_DEC
> > +
> > +input0 =
> > +0x817f8181, 0x7f7f8181, 0x817f7f81, 0x81817f81, 0x81817f81, 0x817f7f81,
> > +0x7f7f7f7f, 0x7f7f7f81, 0x817f7f81, 0x817f7f81, 0x7f7f817f, 0x7f7f7f81,
> > +0x81817f7f, 0x81818181, 0x817f8181, 0x7f817f81, 0x81817f7f, 0x7f7f817f,
> > +0x81817f81, 0x817f8181, 0x7f7f7f81, 0x817f817f, 0x7f817f7f, 0x7f817f7f,
> > +0x7f817f7f, 0x81817f7f, 0x7f818181, 0x817f7f7f, 0x8181817f, 0x81817f7f,
> > +0x7f817f81, 0x7f7f7f7f, 0x7f817f7f, 0x81817f7f, 0x81818181, 0x817f817f,
> > +0x81817f7f, 0x7f81817f, 0x7f7f7f7f, 0x7f7f7f7f, 0x7f818181, 0x7f7f7f81,
> > +0x81817f81, 0x7f817f7f, 0x7f7f7f7f, 0x817f817f, 0x817f817f, 0x7f7f817f,
> > +0x81817f81, 0x7f7f7f7f, 0x7f81817f, 0x817f817f, 0x7f7f8181, 0x7f7f7f7f,
> > +0x817f7f7f, 0x81818181, 0x817f8181, 0x7f7f817f, 0x7f7f8181, 0x7f7f7f7f,
> > +0x7f818181, 0x817f8181, 0x817f7f81, 0x817f8181, 0x817f7f81, 0x81817f7f,
> > +0x7f7f8181, 0x81818181, 0x817f817f, 0x817f7f7f, 0x81818181, 0x7f817f81,
> > +0x7f7f7f81, 0x81817f81, 0x7f817f7f, 0x7f818181, 0x7f7f7f81, 0x817f817f,
> > +0x81818181, 0x81818181, 0x81817f81, 0x81817f81, 0x7f7f8181, 0x817f7f7f,
> > +0x7f81817f, 0x817f817f, 0x81817f7f, 0x817f7f81, 0x81817f7f, 0x7f7f7f81,
> > +0x7f817f81, 0x7f817f81, 0x817f7f7f, 0x7f818181, 0x81818181, 0x7f7f7f7f,
> > +0x7f7f7f7f, 0x8181817f, 0x7f7f7f81, 0x7f817f81, 0x81817f81, 0x7f7f817f,
> > +0x7f81817f, 0x817f8181, 0x7f81817f, 0x7f81817f, 0x817f7f7f, 0x7f81817f,
> > +0x817f7f81, 0x817f7f81, 0x7f817f7f, 0x8181817f, 0x7f81817f, 0x7f7f8181,
> > +0x817f8181, 0x817f7f7f, 0x817f7f81, 0x7f81817f, 0x7f7f817f, 0x7f817f7f,
> > +0x7f7f8181, 0x81818181, 0x7f818181, 0x7f7f817f, 0x7f818181, 0x81818181,
> > +0x7f817f7f, 0x817f817f, 0x817f817f, 0x817f7f7f, 0x81817f81, 0x81817f7f,
> > +0x81817f81, 0x7f817f81, 0x7f817f7f, 0x7f817f7f, 0x817f7f7f, 0x817f7f7f,
> > +0x7f7f7f7f, 0x7f7f7f81, 0x7f7f8181, 0x7f817f81, 0x7f817f7f, 0x817f7f7f,
> > +0x7f7f8181, 0x8181817f, 0x7f7f8181, 0x7f7f7f81, 0x817f7f7f, 0x7f7f7f81,
> > +0x817f8181, 0x7f7f817f, 0x7f81817f, 0x817f817f, 0x7f817f81, 0x7f7f8181,
> > +0x7f818181, 0x7f817f81, 0x81818181, 0x81817f7f, 0x7f81817f, 0x7f81817f,
> > +0x7f7f8181, 0x81818181, 0x817f8181, 0x7f7f817f, 0x7f817f7f, 0x7f7f8181,
> > +0x7f81817f, 0x7f7f817f, 0x7f7f7f7f, 0x7f818181, 0x81817f7f, 0x8181817f,
> > +0x7f81817f, 0x8181817f, 0x81817f81, 0x7f7f7f7f, 0x81818181, 0x7f7f817f,
> > +0x7f81817f, 0x7f7f7f7f, 0x81817f81, 0x817f7f81, 0x817f7f81, 0x817f7f81,
> > +0x81818181, 0x7f7f7f7f, 0x81817f81, 0x817f7f7f, 0x8181817f, 0x7f7f7f81,
> > +0x81817f81, 0x817f7f81, 0x81818181, 0x7f7f7f7f, 0x81817f7f, 0x81817f81,
> > +0x7f7f7f81, 0x7f7f7f7f, 0x817f817f, 0x7f818181, 0x8181817f, 0x81817f81,
> > +0x7f7f7f81, 0x7f817f7f, 0x7f7f7f7f, 0x7f817f81, 0x8181817f, 0x7f7f7f7f,
> > +0x81817f7f, 0x7f7f7f81, 0x7f81817f, 0x7f7f7f7f, 0x7f7f7f81, 0x817f8181,
> > +0x7f7f8181, 0x7f7f7f81, 0x7f7f8181, 0x7f817f7f, 0x81818181, 0x7f81817f,
> > +0x7f818181, 0x7f818181, 0x7f818181, 0x817f7f81, 0x7f7f8181, 0x81818181,
> > +0x7f7f7f7f, 0x7f7f7f7f, 0x817f8181, 0x81818181, 0x7f7f817f, 0x817f8181,
> > +0x81817f7f, 0x817f817f, 0x7f7f817f, 0x7f7f7f7f, 0x817f8181, 0x817f8181,
> > +0x817f8181, 0x81818181, 0x7f7f817f, 0x7f817f81, 0x817f7f81, 0x7f7f7f81,
> > +0x81817f81, 0x7f818181, 0x81817f7f, 0x7f818181, 0x81818181, 0x817f817f,
> > +0x7f817f7f, 0x81818181, 0x817f8181, 0x7f7f7f7f, 0x7f817f81, 0x817f7f7f,
> > +0x7f818181, 0x8181817f, 0x817f817f, 0x7f817f7f, 0x817f7f81, 0x7f818181,
> > +0x817f7f7f, 0x817f7f81, 0x7f7f7f81, 0x81817f81, 0x7f81817f, 0x7f818181,
> > +0x81817f7f, 0x817f7f81, 0x81817f81, 0x7f7f8181, 0x7f7f8181, 0x7f817f81,
> > +0x7f7f817f, 0x817f7f7f, 0x7f7f7f7f, 0x817f7f7f, 0x7f7f8181, 0x817f8181,
> > +0x817f8181, 0x7f817f81, 0x817f8181, 0x8181817f, 0x81817f7f, 0x7f817f7f,
> > +0x7f817f7f, 0x7f817f81, 0x817f817f, 0x817f7f7f, 0x8181817f, 0x817f817f,
> > +0x817f7f81, 0x81817f7f, 0x7f817f7f, 0x7f7f7f7f, 0x7f817f7f, 0x7f7f817f,
> > +0x7f818181, 0x8181817f, 0x817f7f7f, 0x7f817f81, 0x7f7f8181, 0x81817f7f,
> > +0x7f7f817f, 0x7f7f817f, 0x7f817f7f, 0x7f7f817f, 0x7f818181, 0x7f817f7f,
> > +0x817f7f7f, 0x7f817f81, 0x81818181, 0x7f818181, 0x817f8181, 0x8181817f,
> > +0x8181817f, 0x817f7f7f, 0x81817f81, 0x817f7f7f, 0x7f81817f, 0x817f8181,
> > +0x7f818181, 0x7f817f7f, 0x81817f7f, 0x7f81817f, 0x81817f81, 0x7f7f7f81,
> > +0x7f7f7f7f, 0x81818181, 0x817f7f7f, 0x81817f81, 0x817f7f81, 0x81817f7f,
> > +0x81818181, 0x7f7f7f7f, 0x817f817f, 0x7f817f81, 0x817f7f7f, 0x7f817f81,
> > +0x817f8181, 0x7f81817f, 0x7f818181, 0x7f7f8181, 0x817f817f, 0x7f7f7f7f,
> > +0x81818181, 0x7f817f81, 0x81817f81, 0x7f81817f, 0x81818181, 0x7f7f817f,
> > +0x81818181, 0x7f7f7f81, 0x817f7f81, 0x8181817f, 0x7f818181, 0x7f7f7f7f,
> > +0x7f7f7f7f, 0x8181817f, 0x81817f81, 0x81818181, 0x7f7f817f, 0x81817f7f,
> > +0x7f817f81, 0x817f8181, 0x81817f7f, 0x7f817f7f, 0x817f7f7f, 0x7f81817f,
> > +0x817f7f7f, 0x7f7f7f7f, 0x7f7f8181, 0x7f7f8181, 0x7f81817f, 0x7f7f8181,
> > +0x7f7f8181, 0x817f7f81, 0x8181817f, 0x81817f7f, 0x817f8181, 0x817f817f,
> > +0x8181817f, 0x7f7f8181, 0x7f81817f, 0x817f817f, 0x7f817f81, 0x7f817f7f,
> > +0x7f7f8181, 0x81818181, 0x7f817f81, 0x7f7f8181, 0x81817f7f, 0x7f7f7f81,
> > +0x7f7f7f81, 0x7f7f7f7f, 0x7f81817f, 0x7f7f8181, 0x7f7f817f, 0x817f817f,
> > +0x7f7f7f7f, 0x817f8181, 0x7f818181, 0x7f7f817f, 0x8181817f, 0x8181817f,
> > +0x817f7f81, 0x8181817f, 0x817f8181, 0x7f817f7f, 0x81817f7f, 0x81818181,
> > +0x7f7f8181, 0x7f817f81, 0x817f8181, 0x7f817f7f, 0x81818181, 0x81817f81,
> > +0x7f817f81, 0x81817f7f, 0x7f818181, 0x8181817f, 0x7f7f7f81, 0x7f81817f,
> > +0x7f7f8181, 0x81818181, 0x81817f7f, 0x817f8181, 0x81817f7f, 0x7f7f817f,
> > +0x81818181, 0x7f7f8181, 0x7f7f817f, 0x817f817f, 0x7f817f81, 0x7f7f7f7f,
> > +0x7f817f81, 0x7f817f7f, 0x7f81817f, 0x7f7f8181, 0x7f7f817f, 0x81818181,
> > +0x7f7f8181, 0x817f7f81, 0x81817f81, 0x81817f7f, 0x81817f81, 0x81818181,
> > +0x7f817f81, 0x7f7f7f7f, 0x81817f7f, 0x7f817f7f, 0x7f7f817f, 0x81817f7f,
> > +0x81817f7f, 0x7f7f7f7f, 0x817f7f7f, 0x7f817f81, 0x81818181, 0x81817f7f,
> > +0x7f817f7f, 0x8181817f, 0x7f81817f, 0x817f7f81, 0x7f817f7f, 0x7f7f7f7f,
> > +0x817f7f81, 0x7f817f81, 0x81818181, 0x81817f81, 0x7f817f81, 0x81818181,
> > +0x81818181, 0x8181817f, 0x7f7f817f, 0x817f7f7f, 0x817f7f7f, 0x7f7f7f7f,
> > +0x81818181, 0x7f817f7f, 0x817f7f81, 0x7f7f8181, 0x817f8181, 0x81817f7f,
> > +0x81817f7f, 0x817f7f7f, 0x817f817f, 0x7f818181, 0x7f817f7f, 0x817f8181,
> > +0x7f817f7f, 0x817f8181, 0x7f7f817f, 0x81817f7f, 0x8181817f, 0x7f817f81,
> > +0x7f7f7f81, 0x81818181, 0x7f7f7f81, 0x81818181, 0x7f7f817f, 0x817f7f7f,
> > +0x817f817f, 0x7f7f8181, 0x7f7f7f81, 0x7f817f7f, 0x817f8181, 0x817f817f,
> > +0x81818181, 0x81817f7f
> > +
> > +output0 =
> > +0xea7bdad9, 0xabd8311a, 0x4e7ba2e2, 0x5c5c5c85, 0xc400ed50,
> > 0x9bea8883,
> > +0xb7f0
> > +
> > +basegraph=
> > +2
> > +
> > +z_c=
> > +28
> > +
> > +n_cb=
> > +1400
> > +
> > +q_m=
> > +2
> > +
> > +n_filler=
> > +56
> > +
> > +ea =
> > +2048
> > +
> > +eb =
> > +2048
> > +
> > +iter_max=
> > +8
> > +
> > +expected_iter_count=
> > +2
> > +
> > +c =
> > +1
> > +
> > +r =
> > +0
> > +
> > +cab =
> > +0
> > +
> > +rv_index =
> > +0
> > +
> > +code_block_mode =
> > +0
> > +
> > +op_flags =
> > +RTE_BBDEV_LDPC_CRC_TYPE_24B_DROP,
> > RTE_BBDEV_LDPC_DEC_BIG_ENDIAN
> > +
> > +expected_status =
> > +OK
> > diff --git a/app/test-bbdev/test_vectors/ldpc_enc_tb.data b/app/test-
> > bbdev/test_vectors/ldpc_enc_tb.data
> > new file mode 100644
> > index 0000000000..277db673c8
> > --- /dev/null
> > +++ b/app/test-bbdev/test_vectors/ldpc_enc_tb.data
> > @@ -0,0 +1,60 @@
> > +# SPDX-License-Identifier: BSD-3-Clause # Copyright 2020 NXP
> > +
> > +op_type =
> > +RTE_BBDEV_OP_LDPC_ENC
> > +
> > +input0 =
> > +0xea7bdad9, 0xabd8311a, 0x4e7ba2e2, 0x5c5c5c85, 0xc400ed50,
> > 0x9bea8883,
> > +0xb7f0
> > +
> > +output0 =
> > +0x109dd93b, 0x5bfc1299, 0x44a1bd2c, 0x05ce87c4, 0x006cafc4,
> 0x2aa04d17,
> > +0xf803a60d, 0xb9b7032b, 0x5f8af3c9, 0xffa174d1, 0x9ca683dd, 0x0f78551c,
> > +0xb62d51e0, 0xe4996866, 0x42698b36, 0xa4f727f3, 0x445dcd8a,
> 0x84531088,
> > +0x2b1813e3, 0xcf5735a6, 0x342bf366, 0xe6ec7026, 0x9d062f0d, 0x1e8d0f99,
> > +0x01dc0f9d, 0x5041de7a, 0xb1061c0e, 0x776f4313, 0xfb00f397, 0xbb02acb2,
> > +0x7d1952fb, 0x0bf4af7c, 0x794ae785, 0x9c76d198, 0x8082533d,
> 0x4ceb5bb3,
> > +0xc9ae8a54, 0x58e72404, 0x472422c3, 0x8eeb7f58, 0x6c47b68d,
> 0xc9d8f01d,
> > +0x6b585a0f, 0x6d5f0a37, 0x07e91f2f, 0xb5c2fde0, 0x3308684c, 0xabce9336,
> > +0xf345a63e, 0x36011c35, 0xee27b0a2, 0x53fc4be9, 0xe7c5df4b, 0x2cbcf361,
> > +0x4505a23f, 0xcd93f236, 0xc24c05fd, 0xe4cf580c, 0xdf590496, 0x0882eff5,
> > +0x8ccb394f, 0xc2b4b47a, 0x82f1f15e, 0xcfab413a
> > +
> > +basegraph=
> > +2
> > +
> > +z_c=
> > +28
> > +
> > +n_cb=
> > +1400
> > +
> > +q_m=
> > +2
> > +
> > +n_filler=
> > +56
> > +
> > +ea =
> > +2048
> > +
> > +eb =
> > +2048
> > +
> > +c =
> > +1
> > +
> > +r =
> > +0
> > +
> > +cab =
> > +0
> > +
> > +rv_index =
> > +0
> > +
> > +code_block_mode =
> > +0
> > +
> > +op_flags =
> > +RTE_BBDEV_LDPC_CRC_24B_ATTACH,
> > RTE_BBDEV_LDPC_ENC_BIG_ENDIAN
> > +
> > +expected_status =
> > +OK
> > --
> > 2.17.1
