> -----Original Message----- > From: Yigit, Ferruh <ferruh.yi...@intel.com> > Sent: Thursday, September 16, 2021 8:57 PM > To: Xia, Chenbo <chenbo....@intel.com>; Maxime Coquelin > <maxime.coque...@redhat.com>; Gaoxiang Liu <gaoxiangl...@163.com> > Cc: dev@dpdk.org; liugaoxi...@huawei.com; sta...@dpdk.org; Thomas Monjalon > <tho...@monjalon.net> > Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket path > on adding connection > > On 9/16/2021 1:37 PM, Xia, Chenbo wrote: > >> -----Original Message----- > >> From: Maxime Coquelin <maxime.coque...@redhat.com> > >> Sent: Thursday, September 16, 2021 8:33 PM > >> To: Yigit, Ferruh <ferruh.yi...@intel.com>; Gaoxiang Liu > >> <gaoxiangl...@163.com>; Xia, Chenbo <chenbo....@intel.com> > >> Cc: dev@dpdk.org; liugaoxi...@huawei.com; sta...@dpdk.org; Thomas > Monjalon > >> <tho...@monjalon.net> > >> Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket > path on > >> adding connection > >> > >> > >> > >> On 9/16/21 14:28, Ferruh Yigit wrote: > >>> On 9/14/2021 12:30 PM, Maxime Coquelin wrote: > >>>> > >>>> > >>>> On 9/7/21 2:51 AM, Gaoxiang Liu wrote: > >>>>> Add log print of socket path in vhost_user_add_connection. > >>>>> It's useful when adding a mass of socket connections, > >>>>> because the information of every connection is clearer. > >>>>> > >>>>> Fixes: 8f972312b8f4 ("vhost: support vhost-user") > >>>>> Cc: sta...@dpdk.org > >>>>> > >>>>> Signed-off-by: Gaoxiang Liu <gaoxiangl...@163.com> > >>>>> --- > >>>>> lib/vhost/socket.c | 2 +- > >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>>> > >>>> > >>>> > >>>> Applied to dpdk-next-virtio/main. > >>>> > >>> > >>> > >>> Hi Gaoxiang, > >>> > >>> I can see you are in the git history as: > >>> "Gaoxiang Liu <liugaoxi...@huawei.com>" > >>> > >>> Since we are trying to keep unique identity in the git history, I will > use > >> the > >>> one in the git history. Please let us know if that is problem. > >> > >> I fixed up the Author field in my pull request to match the SoB. > >> Did I miss something? > > > > History is Gaoxiang uses @163 email to send patches but signed-off with > @huawei email, > > So I told him to align and Maxime to fix when applying. Maybe it's my > bad about not > > being clear about which to use because it happens several times Gaoxiang > uses two emails. > > > > +1 to align SOB & author (I think checkpatch warns otherwise), but since > in the > git there are commits from 'Gaoxiang Liu <liugaoxi...@huawei.com>', I > think we > should align to that email address.
That's fixed when applying IIRC. If Gaoxiang can only use @163 email to send patch, maybe we should always align to another one...Or it's annoying to fix every time. /Chenbo > > > I notice people from Huawei sometimes use two emails for author and SOB > tag. > > So I have the same question :) > > > > /Chenbo > > > >> > >> Thanks, > >> Maxime > >> > >>> And is there any specific reason to use two different emails? > >> > >> > >>> Thanks, > >>> ferruh > >>> > >