[dpdk-dev] [PATCH] net/iavf: fix rx queue irqs resource leak

[Qiming Chen]

In the iavf_config_rx_queues_irqs function, the memory pointed to by the
intr_handle->intr_vec and qv_map addresses is not released in the
subsequent hook branch, resulting in resource leakage.

Fixes: f593944fc988 ("net/iavf: enable IRQ mapping configuration for large VF")
Cc: sta...@dpdk.org

Signed-off-by: Qiming Chen <chenqiming_hua...@163.com>
---
 drivers/net/iavf/iavf_ethdev.c | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 574cfe055e..280d53a651 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -674,7 +674,7 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev 
*dev,
        if (!qv_map) {
                PMD_DRV_LOG(ERR, "Failed to allocate %d queue-vector map",
                                dev->data->nb_rx_queues);
-               return -1;
+               goto qv_map_alloc_err;
        }
 
        if (!dev->data->dev_conf.intr_conf.rxq ||
@@ -759,7 +759,7 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev 
*dev,
        if (!vf->lv_enabled) {
                if (iavf_config_irq_map(adapter)) {
                        PMD_DRV_LOG(ERR, "config interrupt mapping failed");
-                       return -1;
+                       goto config_irq_map_err;
                }
        } else {
                uint16_t num_qv_maps = dev->data->nb_rx_queues;
@@ -769,7 +769,7 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev 
*dev,
                        if (iavf_config_irq_map_lv(adapter,
                                        IAVF_IRQ_MAP_NUM_PER_BUF, index)) {
                                PMD_DRV_LOG(ERR, "config interrupt mapping for 
large VF failed");
-                               return -1;
+                               goto config_irq_map_err;
                        }
                        num_qv_maps -= IAVF_IRQ_MAP_NUM_PER_BUF;
                        index += IAVF_IRQ_MAP_NUM_PER_BUF;
@@ -777,10 +777,20 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev 
*dev,
 
                if (iavf_config_irq_map_lv(adapter, num_qv_maps, index)) {
                        PMD_DRV_LOG(ERR, "config interrupt mapping for large VF 
failed");
-                       return -1;
+                       goto config_irq_map_err;
                }
        }
        return 0;
+
+config_irq_map_err:
+       rte_free(vf->qv_map);
+       vf->qv_map = NULL;
+
+qv_map_alloc_err:
+       rte_free(intr_handle->intr_vec);
+       intr_handle->intr_vec = NULL;
+
+       return -1;
 }
 
 static int
-- 
2.30.1.windows.1