> -----Original Message----- > From: stable <stable-boun...@dpdk.org> On Behalf Of Qiming Chen > Sent: Friday, September 10, 2021 11:13 > To: dev@dpdk.org > Cc: Xing, Beilei <beilei.x...@intel.com>; Wu, Jingjing > <jingjing...@intel.com>; Qiming Chen > <chenqiming_hua...@163.com>; sta...@dpdk.org > Subject: [dpdk-stable] [PATCH] common/iavf: fix arq resource leak > > In the iavf_init_arq function, if an exception occurs in the > iavf_config_arq_regs function, and the previously applied arq bufs > resource is released. This patch maintains the same modification > as the iavf_init_asq function to roll back resources. > > Fixes: 87aca6d8d8a4 ("net/iavf/base: fix command buffer memory leak") > Cc: sta...@dpdk.org > > Signed-off-by: Qiming Chen <chenqiming_hua...@163.com> > --- > drivers/common/iavf/iavf_adminq.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >
Can't image that you ARE superman to cover ixgbe,ixgbevf, i40e, now iavf. It MUST BE done by some code scan tool, I don't believe you have real time to read the whole code. Right ? Sometimes, Defensive programming is good, but ... I prefer to the PMD can run well every time, if failed, it must have some bugs. > -- > 2.30.1.windows.1